Bug 122959 – [CSSRegions] Move regions auto-size code into RenderNamedFlowFragment

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Mihnea Ovidenie]

After https://bugs.webkit.org/show_bug.cgi?id=119135, the region auto-size code should be moved from RenderRegion class to the new RenderNamedFlowFragment class. RenderNamedFlowFragment will contain functionality specific to CSSRegions only, as it is the case for region auto-size.

[Andrei Bucur]

Created attachment 220633 [details]
Patch

[Mihnea Ovidenie]

(In reply to comment #1)
> Created an attachment (id=220633) [details]
> Patch

Would not have been easier to make *hasAutoLogicalHeight* a virtual which returns false in RenderRegion and do the check in RenderNamedFlowFragment? The static implementation in RenderFlowThread calls isRenderNamedFlowFragment() which is already a virtual method.

[Andrei Bucur]

Created attachment 220704 [details]
Patch

[Mihnea Ovidenie]

Comment on attachment 220704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220704&action=review

r=me, please take a look at the comments before landing.

> Source/WebCore/rendering/RenderNamedFlowFragment.cpp:159
> +    ASSERT(newLogicalHeight < LayoutUnit::max() / 2);

I would use RenderFlowThread::maxLogicalHeight() instead of LayoutUnit::max() / 2.

> Source/WebCore/rendering/RenderTreeAsText.cpp:671
> +            if (isRenderNamedFlowFragment && toRenderNamedFlowFragment(renderRegion)->hasAutoLogicalHeight())

Since hasAutoLogicalHeight always returns false for RenderRegion, you can still use the previous condition.

[Andrei Bucur]

Created attachment 220709 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 220709 [details]
Patch

Clearing flags on attachment: 220709

Committed r161553: <http://trac.webkit.org/changeset/161553>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.