WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
119135
[CSS Regions] Anonymous nested regions
https://bugs.webkit.org/show_bug.cgi?id=119135
Summary
[CSS Regions] Anonymous nested regions
Catalin badea
Reported
2013-07-26 01:13:10 PDT
This is a prototype for a new approach on how region renderers are created and handled. The idea is to have the block elements with the region property create their normal renderer and add a region renderer as its only child. The nested region does not have a node and takes the size of the container. Also, the parent should be prevented from adding other children, with the exception of pseudo elements like :before and :after.
Attachments
wip patch
(18.37 KB, patch)
2013-07-26 01:14 PDT
,
Catalin badea
no flags
Details
Formatted Diff
Diff
WIP
(15.38 KB, patch)
2013-08-07 16:08 PDT
,
Catalin badea
no flags
Details
Formatted Diff
Diff
WIP
(15.36 KB, patch)
2013-08-08 02:08 PDT
,
Catalin badea
no flags
Details
Formatted Diff
Diff
WIP
(16.31 KB, patch)
2013-08-12 14:10 PDT
,
Catalin badea
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
(879.65 KB, application/zip)
2013-08-12 16:24 PDT
,
Build Bot
no flags
Details
WIP
(20.60 KB, patch)
2013-08-28 02:18 PDT
,
Catalin badea
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
(750.27 KB, application/zip)
2013-08-28 08:15 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
(774.90 KB, application/zip)
2013-08-28 11:31 PDT
,
Build Bot
no flags
Details
WIP2 patch
(34.06 KB, application/octet-stream)
2013-09-24 07:12 PDT
,
Mihnea Ovidenie
no flags
Details
WIP3
(62.66 KB, patch)
2013-10-07 08:36 PDT
,
Mihnea Ovidenie
no flags
Details
Formatted Diff
Diff
WIP4
(72.03 KB, patch)
2013-10-08 10:16 PDT
,
Mihnea Ovidenie
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Patch
(77.41 KB, patch)
2013-10-09 01:18 PDT
,
Mihnea Ovidenie
no flags
Details
Formatted Diff
Diff
Patch 2
(53.85 KB, patch)
2013-10-15 09:49 PDT
,
Mihnea Ovidenie
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Patch 3
(53.85 KB, patch)
2013-10-16 00:00 PDT
,
Mihnea Ovidenie
no flags
Details
Formatted Diff
Diff
Patch for landing
(56.95 KB, patch)
2013-10-17 01:30 PDT
,
Mihnea Ovidenie
no flags
Details
Formatted Diff
Diff
Show Obsolete
(10)
View All
Add attachment
proposed patch, testcase, etc.
Catalin badea
Comment 1
2013-07-26 01:14:15 PDT
Created
attachment 207512
[details]
wip patch
Catalin badea
Comment 2
2013-08-07 16:08:22 PDT
Created
attachment 208304
[details]
WIP
Darin Adler
Comment 3
2013-08-07 16:12:00 PDT
Comment on
attachment 208304
[details]
WIP Looks like a backwards patch.
Catalin badea
Comment 4
2013-08-08 02:08:55 PDT
Created
attachment 208319
[details]
WIP
Catalin badea
Comment 5
2013-08-12 14:10:27 PDT
Created
attachment 208559
[details]
WIP
Build Bot
Comment 6
2013-08-12 16:24:11 PDT
Comment on
attachment 208559
[details]
WIP
Attachment 208559
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/1453242
New failing tests: fast/regions/flow-body-in-html.html fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes.html fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html fast/regions/flows-dependency-same-flow.html http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html http/tests/inspector/inspect-element.html fast/regions/flow-content-basic-vertical.html fast/regions/shape-inside/shape-inside-with-region-borders.html fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-multiple-shapes.html fast/regions/autoheight-regions-mark.html fast/regions/overflow-in-variable-width-regions.html fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html fast/regions/multiple-directionality-changes-in-variable-width-regions.html fast/regions/offsetLeft-offsetTop-in-multiple-regions.html fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes.html fast/regions/overflow-in-uniform-regions-dynamic.html fast/regions/shape-inside/shape-inside-on-regions-block-content-basic-overflow-shape-top-offset.html fast/regions/overflow-moving-below-floats-in-variable-width-regions.html fast/regions/flow-content-basic.html fast/regions/flows-dependency-dynamic-remove.html fast/repaint/line-flow-with-floats-in-regions.html fast/repaint/region-painting-invalidation.html fast/repaint/region-painting-via-layout.html fast/regions/overflow-rtl-in-variable-width-regions.html fast/regions/flow-content-basic-vertical-rl.html fast/repaint/japanese-rl-selection-repaint-in-regions.html fast/regions/shape-inside/shape-inside-on-regions-inline-content-basic-overflow-shape-top-offset.html fast/loader/javascript-url-in-object.html fast/repaint/overflow-flipped-writing-mode-block-in-regions.html
Build Bot
Comment 7
2013-08-12 16:24:14 PDT
Created
attachment 208572
[details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Catalin badea
Comment 8
2013-08-28 02:18:57 PDT
Created
attachment 209858
[details]
WIP
Build Bot
Comment 9
2013-08-28 08:14:56 PDT
Comment on
attachment 209858
[details]
WIP
Attachment 209858
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/1628294
New failing tests: fast/regions/flow-body-in-html.html fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes.html fast/regions/flows-dependency-same-flow.html fast/regions/layers/dynamic-layer-removed-with-no-layout.html http/tests/inspector/inspect-element.html fast/regions/flow-content-basic-vertical.html fast/regions/shape-inside/shape-inside-with-region-borders.html fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-multiple-shapes.html fast/regions/autoheight-regions-mark.html fast/regions/layers/regions-promoted-to-layers-vertical-rl.html fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html fast/regions/multiple-directionality-changes-in-variable-width-regions.html fast/regions/offsetLeft-offsetTop-in-multiple-regions.html fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes.html fast/regions/overflow-in-uniform-regions-dynamic.html fast/regions/shape-inside/shape-inside-on-regions-block-content-basic-overflow-shape-top-offset.html fast/regions/flow-content-basic.html fast/regions/flows-dependency-dynamic-remove.html fast/repaint/line-flow-with-floats-in-regions.html fast/repaint/region-painting-invalidation.html fast/repaint/region-painting-via-layout.html fast/regions/layers/regions-promoted-to-layers.html fast/regions/flow-content-basic-vertical-rl.html fast/regions/layers/dynamic-layer-added-with-no-layout.html fast/regions/layers/regions-promoted-to-layers-vertical-lr.html fast/repaint/japanese-rl-selection-repaint-in-regions.html fast/regions/shape-inside/shape-inside-on-regions-inline-content-basic-overflow-shape-top-offset.html fast/repaint/overflow-flipped-writing-mode-block-in-regions.html fast/regions/layers/regions-promoted-to-layers-horizontal-bt.html fast/regions/content-flowed-into-pseudo-regions.html
Build Bot
Comment 10
2013-08-28 08:15:00 PDT
Created
attachment 209889
[details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
Darin Adler
Comment 11
2013-08-28 09:43:57 PDT
Comment on
attachment 209858
[details]
WIP View in context:
https://bugs.webkit.org/attachment.cgi?id=209858&action=review
> Source/WebCore/rendering/RenderObject.h:645 > + Node* generatingNode() const > + { > + if (isRenderRegion() && parent()) > + return parent()->node(); > + return isPseudoElement() ? generatingPseudoHostElement() : node(); > + }
Can this return Element*, or could it actually be a non-Element node in some case? This function is getting kind of long. Does it really need to be inlined? If it does, can we at least put it outside the class definition?
Build Bot
Comment 12
2013-08-28 11:31:53 PDT
Comment on
attachment 209858
[details]
WIP
Attachment 209858
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/1621325
New failing tests: fast/regions/flow-body-in-html.html fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes.html fast/regions/flows-dependency-same-flow.html fast/regions/layers/dynamic-layer-removed-with-no-layout.html http/tests/inspector/inspect-element.html fast/regions/flow-content-basic-vertical.html fast/regions/shape-inside/shape-inside-with-region-borders.html fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-multiple-shapes.html fast/regions/autoheight-regions-mark.html fast/regions/layers/regions-promoted-to-layers-vertical-rl.html fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html fast/regions/multiple-directionality-changes-in-variable-width-regions.html fast/regions/offsetLeft-offsetTop-in-multiple-regions.html fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes.html fast/regions/overflow-in-uniform-regions-dynamic.html fast/regions/shape-inside/shape-inside-on-regions-block-content-basic-overflow-shape-top-offset.html fast/regions/flow-content-basic.html fast/regions/flows-dependency-dynamic-remove.html fast/repaint/line-flow-with-floats-in-regions.html fast/repaint/region-painting-invalidation.html fast/repaint/region-painting-via-layout.html fast/regions/layers/regions-promoted-to-layers.html fast/regions/flow-content-basic-vertical-rl.html fast/regions/layers/dynamic-layer-added-with-no-layout.html fast/regions/layers/regions-promoted-to-layers-vertical-lr.html fast/repaint/japanese-rl-selection-repaint-in-regions.html fast/regions/shape-inside/shape-inside-on-regions-inline-content-basic-overflow-shape-top-offset.html fast/repaint/overflow-flipped-writing-mode-block-in-regions.html fast/regions/layers/regions-promoted-to-layers-horizontal-bt.html fast/regions/content-flowed-into-pseudo-regions.html
Build Bot
Comment 13
2013-08-28 11:31:56 PDT
Created
attachment 209911
[details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Build Bot
Comment 14
2013-08-28 18:21:59 PDT
Comment on
attachment 209858
[details]
WIP
Attachment 209858
[details]
did not pass win-ews (win): Output:
http://webkit-queues.appspot.com/results/1592795
Mihnea Ovidenie
Comment 15
2013-09-24 07:12:30 PDT
Created
attachment 212464
[details]
WIP2 patch WIP2 patch
Mihnea Ovidenie
Comment 16
2013-10-07 08:36:52 PDT
Created
attachment 213588
[details]
WIP3
Mihnea Ovidenie
Comment 17
2013-10-08 10:16:48 PDT
Created
attachment 213697
[details]
WIP4
WebKit Commit Bot
Comment 18
2013-10-08 10:17:48 PDT
Attachment 213697
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt', u'LayoutTests/fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt', u'LayoutTests/fast/regions/element-inflow-fixed-from-outflow-static-expected.txt', u'LayoutTests/fast/regions/element-outflow-static-from-inflow-fixed-expected.txt', u'LayoutTests/fast/regions/table-caption-as-region-expected.html', u'LayoutTests/fast/regions/table-caption-as-region.html', u'LayoutTests/fast/regions/table-cell-as-region-expected.html', u'LayoutTests/fast/regions/table-cell-as-region.html', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/WebKitNamedFlow.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderElement.cpp', u'Source/WebCore/rendering/RenderElement.h', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderMultiColumnSet.cpp', u'Source/WebCore/rendering/RenderMultiColumnSet.h', u'Source/WebCore/rendering/RenderNamedFlowFragment.cpp', u'Source/WebCore/rendering/RenderNamedFlowFragment.h', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderTableCaption.cpp', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.h', u'Source/WebCore/style/StyleResolveTree.cpp']" exit_code: 1 Source/WebCore/inspector/InspectorOverlay.cpp:48: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/rendering/RenderElement.h:256: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 19
2013-10-08 10:58:00 PDT
Comment on
attachment 213697
[details]
WIP4
Attachment 213697
[details]
did not pass win-ews (win): Output:
http://webkit-queues.appspot.com/results/3750100
Mihnea Ovidenie
Comment 20
2013-10-09 01:18:09 PDT
Created
attachment 213761
[details]
Patch
Build Bot
Comment 21
2013-10-09 03:03:09 PDT
Comment on
attachment 213761
[details]
Patch
Attachment 213761
[details]
did not pass win-ews (win): Output:
http://webkit-queues.appspot.com/results/3766032
Dave Hyatt
Comment 22
2013-10-09 16:17:11 PDT
Comment on
attachment 213761
[details]
Patch Is RenderBLockFlow the correct place? You don't intend to allow flexboxes to be regions?
Mihnea Ovidenie
Comment 23
2013-10-09 19:31:04 PDT
(In reply to
comment #22
)
> (From update of
attachment 213761
[details]
) > Is RenderBLockFlow the correct place? You don't intend to allow flexboxes to be regions?
No, the flexbox element and the grid element will not become regions, as described in the spec: "The flex and grid display values do not result in block containers (they are defined as flex containers and grid elements, respectively). So ‘flow-from’ combined with those display values does not result in a CSS Region."
http://dev.w3.org/csswg/css-regions/#the-flow-from-property
.
Mihnea Ovidenie
Comment 24
2013-10-15 09:49:02 PDT
Created
attachment 214275
[details]
Patch 2 New patch with just the basic functionality. Region styling code still in RenderRegion and can be moved in a follow up patch, same for autoheight.
Build Bot
Comment 25
2013-10-15 11:37:42 PDT
Comment on
attachment 214275
[details]
Patch 2
Attachment 214275
[details]
did not pass win-ews (win): Output:
http://webkit-queues.appspot.com/results/3482050
Mihnea Ovidenie
Comment 26
2013-10-16 00:00:14 PDT
Created
attachment 214344
[details]
Patch 3 Same patch with Win build fix as shapes are not enabled by default on Win.
Dave Hyatt
Comment 27
2013-10-16 12:21:05 PDT
Comment on
attachment 214344
[details]
Patch 3 r=me
Mihnea Ovidenie
Comment 28
2013-10-17 01:30:08 PDT
Created
attachment 214433
[details]
Patch for landing
WebKit Commit Bot
Comment 29
2013-10-17 02:00:44 PDT
Comment on
attachment 214433
[details]
Patch for landing Clearing flags on attachment: 214433 Committed
r157567
: <
http://trac.webkit.org/changeset/157567
>
WebKit Commit Bot
Comment 30
2013-10-17 02:00:50 PDT
All reviewed patches have been landed. Closing bug.
Mihai Maerean
Comment 31
2013-10-17 05:30:07 PDT
Comment on
attachment 214433
[details]
Patch for landing View in context:
https://bugs.webkit.org/attachment.cgi?id=214433&action=review
> Source/WebCore/ChangeLog:9 > + fast/regions/table-cell-as-region.html
if list items can now be CSS Regions, you can add tests for that too.
> Source/WebCore/GNUmakefile.list.am:4394 > + Source/WebCore/rendering/RenderNamedFlowFragment.cpp \
nit: the indentation for these lines should be the same as for the rest of the lines in the file.
> Source/WebCore/inspector/InspectorOverlay.cpp:394 > + RenderBlockFlow* regionContainer = toRenderBlockFlow(region->parent());
maybe we could have a RenderBlockFlow operator in RenderRegion that returns parent().
> Source/WebCore/rendering/RenderListItem.cpp:84 > + RenderBlockFlow::insertedIntoTree();
if list items can now be CSS Regions, you can add tests for that too.
> Source/WebCore/rendering/RenderNamedFlowFragment.h:40 > +class RenderNamedFlowFragment : public RenderRegion {
1. it would really help if you add a short comment explaining what use cases this class enables and how the render tree looks after this class was introduced. 2. in my opinion, the RenderAnonymousRegion name does a better job of explaining what it does than RenderNamedFlowFragment. The CSS Break specification defines a fragment as "the portion of a box that belongs to exactly one fragmentainer". This class is not about that concept.
> Source/WebCore/rendering/RenderTreeAsText.cpp:578 > + if (!o.isRenderNamedFlowFragmentContainer()) {
This hides the renderers of the anonymous regions from the output, which doesn't happen for the other types of anonymous renderers in the tree.
Mihnea Ovidenie
Comment 32
2013-10-17 07:15:05 PDT
(In reply to
comment #31
)
> (From update of
attachment 214433
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=214433&action=review
> > > Source/WebCore/ChangeLog:9 > > + fast/regions/table-cell-as-region.html > > if list items can now be CSS Regions, you can add tests for that too. >
Filed
https://bugs.webkit.org/show_bug.cgi?id=122961
> > Source/WebCore/GNUmakefile.list.am:4394 > > + Source/WebCore/rendering/RenderNamedFlowFragment.cpp \ > > nit: the indentation for these lines should be the same as for the rest of the lines in the file. > > > Source/WebCore/inspector/InspectorOverlay.cpp:394 > > + RenderBlockFlow* regionContainer = toRenderBlockFlow(region->parent()); > > maybe we could have a RenderBlockFlow operator in RenderRegion that returns parent(). > > > Source/WebCore/rendering/RenderListItem.cpp:84 > > + RenderBlockFlow::insertedIntoTree(); > > if list items can now be CSS Regions, you can add tests for that too. > > > Source/WebCore/rendering/RenderNamedFlowFragment.h:40 > > +class RenderNamedFlowFragment : public RenderRegion { > > 1. it would really help if you add a short comment explaining what use cases this class enables and how the render tree looks after this class was introduced. > > 2. in my opinion, the RenderAnonymousRegion name does a better job of explaining what it does than RenderNamedFlowFragment. The CSS Break specification defines a fragment as "the portion of a box that belongs to exactly one fragmentainer". This class is not about that concept. > > > Source/WebCore/rendering/RenderTreeAsText.cpp:578 > > + if (!o.isRenderNamedFlowFragmentContainer()) { > > This hides the renderers of the anonymous regions from the output, which doesn't happen for the other types of anonymous renderers in the tree.
Filed
https://bugs.webkit.org/show_bug.cgi?id=122963
, as it would mean changing a lot of tests.
Andreas Kling
Comment 33
2013-10-17 11:27:07 PDT
I think this may have regressed Parser/html5-full-render by ~1.1% and Parser/html-parser by ~2%:
https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mountainlion%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22mac-mountainlion%22%2C%22Parser%2Fhtml-parser%3ATime%22%5D%5D
Andreas Kling
Comment 34
2013-10-17 11:48:19 PDT
Comment on
attachment 214433
[details]
Patch for landing View in context:
https://bugs.webkit.org/attachment.cgi?id=214433&action=review
> Source/WebCore/dom/Element.cpp:2764 > document().updateLayoutIgnorePendingStylesheets();
Unrelated, but it's weird that this function forces a layout even if the CSS regions are disabled.
> Source/WebCore/rendering/RenderBlockFlow.cpp:280 > + if (namedFlowFragmentNeedsUpdate()) > + relayoutChildren = true;
Could we avoid calling namedFlowFragmentNeedsUpdate() if relayoutChildren is already true? I feel like this block of code could be structured differently to avoid unnecessary work.
> Source/WebCore/rendering/RenderBlockFlow.cpp:2371 > + if (document().cssRegionsEnabled() && style()->isDisplayRegionType() && !style()->regionThread().isEmpty()) {
I think we should put the cssRegionsEnabled() check at the head of this function. There's no need to check anything else if the feature is disabled.
> Source/WebCore/rendering/RenderBlockFlow.cpp:2408 > + if (!m_rareData) > + m_rareData = adoptPtr(new RenderBlockFlowRareData(this));
This pattern seems to repeat a lot. It should be done in a dedicated function, e.g: RenderBlockFlowRareData& RenderBlockFlow::ensureRareData()
> Source/WebCore/rendering/RenderBlockFlow.h:98 > + , m_renderNamedFlowFragment(0)
0 -> nullptr
> Source/WebCore/rendering/RenderElement.h:263 > + if (isRenderNamedFlowFragment() && parent())
We should swap the order of these checks to avoid the virtual call when possible.
> Source/WebCore/rendering/RenderNamedFlowFragment.h:40 > +class RenderNamedFlowFragment : public RenderRegion {
Unless you are going to inherit from this class, it should be marked FINAL.
> Source/WebCore/rendering/RenderNamedFlowFragment.h:48 > + virtual bool isRenderNamedFlowFragment() const OVERRIDE FINAL { return true; } > + virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);
These should be private. styleDidChange() needs OVERRIDE
> Source/WebCore/rendering/RenderNamedFlowFragment.h:55 > +protected: > + virtual bool shouldHaveAutoLogicalHeight() const;
When you mark the class FINAL, this should be marked with private. Also it needs OVERRIDE.
> Source/WebCore/rendering/RenderNamedFlowFragment.h:58 > + virtual const char* renderName() const { return "RenderNamedFlowFragment"; }
Needs OVERRIDE.
> Source/WebCore/rendering/RenderObject.cpp:2567 > +bool RenderObject::isRenderNamedFlowFragmentContainer() const > +{ > + if (!isRenderBlockFlow()) > + return false; > + > + return toRenderBlockFlow(this)->renderNamedFlowFragment(); > +}
This function belongs in RenderElement. We should move it there to avoid an extra branch in isRenderBlockFlow().
Andrei Bucur
Comment 35
2013-10-18 03:42:06 PDT
Ok, I'm going to look at this now. Stay tuned.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug