Bug 122555 - [arm] Inverted src and dest FP registers in DFG speculative JIT when using hardfp
Summary: [arm] Inverted src and dest FP registers in DFG speculative JIT when using ha...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 108645
  Show dependency tree / graph
 
Reported: 2013-10-09 09:31 PDT by Julien Brianceau
Modified: 2013-10-09 11:03 PDT (History)
6 users (show)

See Also:

Attachments
Fix src and dest FP registers inversion when CPU(ARM) && CPU(ARM_HARDFP). (1.63 KB, patch)
2013-10-09 09:33 PDT, Julien Brianceau 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-10-09 09:31:10 PDT 
I think that the src and dest registers in moveDouble() call are inverted when CPU(ARM) and CPU(ARM_HARDFP).
Comment 1 Julien Brianceau 2013-10-09 09:33:16 PDT 
Created attachment 213784 [details]
Fix src and dest FP registers inversion when CPU(ARM) && CPU(ARM_HARDFP).
Comment 2 Julien Brianceau 2013-10-09 09:35:36 PDT 
Comment on attachment 213784 [details]
Fix src and dest FP registers inversion when CPU(ARM) && CPU(ARM_HARDFP).

Please note that I found this by reading the code and I don't have an ARM environment to validate this patch.
Comment 3 WebKit Commit Bot 2013-10-09 10:01:07 PDT 
Comment on attachment 213784 [details]
Fix src and dest FP registers inversion when CPU(ARM) && CPU(ARM_HARDFP).

Clearing flags on attachment: 213784

Committed r157173: <http://trac.webkit.org/changeset/157173>
Comment 4 WebKit Commit Bot 2013-10-09 10:01:10 PDT 
All reviewed patches have been landed.  Closing bug.