Bug 122405 - [CSSRegions] Computed z-Index should return 0 instead of auto for a region
Summary: [CSSRegions] Computed z-Index should return 0 instead of auto for a region
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-05 22:29 PDT by Mihnea Ovidenie
Modified: 2013-10-08 10:32 PDT (History)
9 users (show)

See Also:

Attachments
Patch (7.52 KB, patch)
2013-10-05 22:34 PDT, Mihnea Ovidenie 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihnea Ovidenie 2013-10-05 22:29:19 PDT 
Because a region establishes a stacking context.
Comment 1 Mihnea Ovidenie 2013-10-05 22:34:13 PDT 
Created attachment 213496 [details]
Patch
Comment 2 Mihnea Ovidenie 2013-10-07 04:37:27 PDT 
Regarding the test file, i tested the behavior of browsers with a similar test with opacity instead of -webkit-flow-from. Only the WebKit browsers return 0, the other browsers FF/IE/Opera return auto.

Since region elements do not have children and paint the flow thread content, i resorted to this test since we already have tests for regions as stacking contexts with siblings.
Comment 3 Mihnea Ovidenie 2013-10-07 04:44:30 PDT 
An old (related) WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=15562 about computed zIndex.
Comment 4 Andrei Bucur 2013-10-08 10:07:18 PDT 
Comment on attachment 213496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213496&action=review

> Source/WebCore/rendering/style/RenderStyle.h:892
> +    bool hasStyleRegion() const { return !rareNonInheritedData->m_regionThread.isNull(); }

Would "isNamedFlowRegion" be more precise?
Comment 5 Dave Hyatt 2013-10-08 10:09:47 PDT 
Comment on attachment 213496 [details]
Patch

r=me,
Comment 6 WebKit Commit Bot 2013-10-08 10:32:18 PDT 
Comment on attachment 213496 [details]
Patch

Clearing flags on attachment: 213496

Committed r157121: <http://trac.webkit.org/changeset/157121>
Comment 7 WebKit Commit Bot 2013-10-08 10:32:20 PDT 
All reviewed patches have been landed.  Closing bug.