Bug 122254 - [CSS Shapes] Support the shape-image-threshold property
Summary: [CSS Shapes] Support the shape-image-threshold property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on: 122216
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-02 18:20 PDT by Hans Muller
Modified: 2013-10-03 13:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.49 KB, patch)
2013-10-03 08:36 PDT, Hans Muller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2013-10-02 18:20:19 PDT 
Make the Shape class use the value of the shape-image-threshold property.

The spec for this property is http://dev.w3.org/csswg/css-shapes-1/#shape-image-threshold-property
Comment 1 Hans Muller 2013-10-03 08:36:00 PDT 
Created attachment 213250 [details]
Patch

Replace the hardwired 0 Shape::createShape() threshold parameter with the style's shapeImageThreshold() value (which has been clamped to [0,1]).
Comment 2 Andreas Kling 2013-10-03 12:38:55 PDT 
Comment on attachment 213250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213250&action=review

r=me

> Source/WebCore/rendering/shapes/ShapeInfo.cpp:62
> -        m_shape = Shape::createShape(shapeValue->image(), 0, m_shapeLogicalSize, writingMode, margin, padding);
> +        m_shape = Shape::createShape(shapeValue->image(), shapeImageThreshold, m_shapeLogicalSize, writingMode, margin, padding);

Maybe Shape::createShape() should ASSERT that shapeImageThreshold is between 0 and 1?
Comment 3 WebKit Commit Bot 2013-10-03 13:03:28 PDT 
Comment on attachment 213250 [details]
Patch

Clearing flags on attachment: 213250

Committed r156852: <http://trac.webkit.org/changeset/156852>
Comment 4 WebKit Commit Bot 2013-10-03 13:03:30 PDT 
All reviewed patches have been landed.  Closing bug.