The current Shapes implementation, notably Shape::createShape(const StyleImage* styleImage, ...), always uses 0 for this threshold.
Created attachment 213211 [details] Patch Added support for the CSS shape-image-threshold property. This change just enables parsing the property, it's not connected to the Shapes code yet. The number valued shape-image-threshold property is defined here: http://dev.w3.org/csswg/css-shapes-1/#shape-image-threshold-property. Its computed value is clamped to the range [0, 1].
Comment on attachment 213211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213211&action=review You didn't mark this patch r?, but it looks good to me. > LayoutTests/fast/shapes/parsing/parsing-shape-image-threshold.html:8 > +<script src="script-tests/parsing-shape-image-threshold.js"></script> It seems silly to have the test logic in a separate file. make-new-script-tests generates a single HTML file with everything these days.
Comment on attachment 213211 [details] Patch r=me
(In reply to comment #2) > (From update of attachment 213211 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=213211&action=review > > LayoutTests/fast/shapes/parsing/parsing-shape-image-threshold.html:8 > > +<script src="script-tests/parsing-shape-image-threshold.js"></script> > > It seems silly to have the test logic in a separate file. > make-new-script-tests generates a single HTML file with everything these days. Will make this change in a separate patch: https://bugs.webkit.org/show_bug.cgi?id=122251
Comment on attachment 213211 [details] Patch Clearing flags on attachment: 213211 Committed r156814: <http://trac.webkit.org/changeset/156814>
All reviewed patches have been landed. Closing bug.