Bug 122197 – [CSS Shapes] Shape Outside should relayout when set dynamically

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Bear Travis]

Shape outside on a float should cause relayout when added, modified, or removed dynamically.

Test case has a shape-outside dynamically added after a 5 second delay. Relayout does not currently occur.

[Bear Travis]

Created attachment 213135 [details]
Test case

[Bear Travis]

Created attachment 213298 [details]
Patch

[Bear Travis]

Created attachment 213301 [details]
Updated patch

Adding overhang tests and cleaning up existing tests

[Alexandru Chiculita]

Comment on attachment 213301 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213301&action=review

This is unrelated to your current change, but I think we need to consolidate removeFloatingOrPositionedChildFromBlockLists to avoid calling it twice in the same style change. Currently there are already two places that could call removeFloatingOrPositionedChildFromBlockLists in the same style change. Can you add a bug for it please?

r=me

> LayoutTests/fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html:9
> +        if (document.body)
> +            document.body.offsetTop;
> +        else if (document.documentElement)
> +            document.documentElement.offsetTop;

nit: I think that onload will always have a document.body.

> LayoutTests/fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html:14
> +        el.setAttribute('class', 'shape rectangle50');

nit: you can use el.className = "";

[Bear Travis]

Created attachment 213385 [details]
Incorporating feedback

[WebKit Commit Bot]

Comment on attachment 213385 [details]
Incorporating feedback

Clearing flags on attachment: 213385

Committed r156905: <http://trac.webkit.org/changeset/156905>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Bear Travis]

*** Bug 114527 has been marked as a duplicate of this bug. ***