Bug 122191 - Please clarify "pending" reporting at build.webkit.org/dashboard
Summary: Please clarify "pending" reporting at build.webkit.org/dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on: 122180
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-01 15:41 PDT by Alexey Proskuryakov
Modified: 2013-12-26 09:58 PST (History)
4 users (show)

See Also:


Attachments
proposed patch (19.66 KB, patch)
2013-12-25 22:55 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
screenshot (413.87 KB, image/png)
2013-12-25 23:28 PST, Alexey Proskuryakov
no flags Details
with minor fixes (19.68 KB, patch)
2013-12-25 23:42 PST, Alexey Proskuryakov
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-10-01 15:41:08 PDT
In Buildbot, pending runs are ones that haven't started yet. It's quite misleading if dashboard reports pending and current run as "pending".

I don't think that we need a number for pending runs. Generally, Buildbot just coalesces all revisions, testing the most current one. So the number just means "how many incoming requests came during the current run".

Some bots could be configured to not coalesce, or even to backtrack when idle. I'm not sure of all the details.
Comment 1 Alexey Proskuryakov 2013-10-16 10:40:06 PDT
I think that there are two use cases for pending build indication:

1. It helps to know whether a fix for current problems has already landed. Currently, I have to go to either my webkit-changes folder in Mail, or to trac.webkit.org.

This is tracked as bug 122180.

2. Sometimes bots get stuck, and looking at pending builds helps discover that.

I think that this we should display ETA and last finish time for each bot (see also bug 122661). It's slightly non-trivial because there are sometimes multiple bots per tester, but not hard - the information is all available in JSON status.

One way or another, the current situation with displaying pending build count is very confusing, especially so for testers, which will combine all pending runs for the next cycle.
Comment 2 Tim Horton 2013-11-20 15:41:36 PST
<rdar://problem/15519672>
Comment 3 Alexey Proskuryakov 2013-12-25 22:55:55 PST
Created attachment 220023 [details]
proposed patch
Comment 4 Alexey Proskuryakov 2013-12-25 23:28:40 PST
Created attachment 220026 [details]
screenshot
Comment 5 Alexey Proskuryakov 2013-12-25 23:42:10 PST
Created attachment 220027 [details]
with minor fixes

Fixed an error caused by a last minute rename, and clamped pending revision count t be non-negative (it could theoretically become negative if trac was down or slow to respond).
Comment 6 Alexey Proskuryakov 2013-12-26 09:58:32 PST
Committed <http://trac.webkit.org/r161090>.