Bug 122178 - Variable event stream (for DFG OSR exit) should be explicit about where on the stack a SetLocal put a value
Summary: Variable event stream (for DFG OSR exit) should be explicit about where on th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
: 108019 (view as bug list)
Depends on:
Blocks: 122024
  Show dependency tree / graph
 
Reported: 2013-10-01 14:16 PDT by Filip Pizlo
Modified: 2013-10-01 16:29 PDT (History)
9 users (show)

See Also:

Attachments
work in progress (25.13 KB, patch)
2013-10-01 14:21 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (31.62 KB, patch)
2013-10-01 14:35 PDT, Filip Pizlo 		ggaren: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-10-01 14:16:25 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-10-01 14:16:37 PDT 
*** Bug 108019 has been marked as a duplicate of this bug. ***
Comment 2 Filip Pizlo 2013-10-01 14:21:09 PDT 
Created attachment 213119 [details]
work in progress
Comment 3 Filip Pizlo 2013-10-01 14:35:56 PDT 
Created attachment 213121 [details]
the patch
Comment 4 Geoffrey Garen 2013-10-01 14:55:35 PDT 
Comment on attachment 213121 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213121&action=review

r=me

> Source/JavaScriptCore/dfg/DFGVariableEvent.h:234
> +        return static_cast<VirtualRegister>(m_representation.virtualReg);

You can just use constructor syntax here: VirtualRegister(m_representation.virtualReg).

> Source/JavaScriptCore/dfg/DFGVariableEvent.h:240
> +        return static_cast<VirtualRegister>(m_representation.virtualReg);

Ditto.

> Source/JavaScriptCore/dfg/DFGVariableEvent.h:246
> +        return static_cast<VirtualRegister>(m_which.virtualReg);

You can just use constructor syntax here: VirtualRegister(m_which.virtualReg).
Comment 5 EFL EWS Bot 2013-10-01 15:17:15 PDT 
Comment on attachment 213121 [details]
the patch

Attachment 213121 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/2902186
Comment 6 Filip Pizlo 2013-10-01 16:00:53 PDT 
(In reply to comment #5)
> (From update of attachment 213121 [details])
> Attachment 213121 [details] did not pass efl-wk2-ews (efl-wk2):
> Output: http://webkit-queues.appspot.com/results/2902186

Looks like an ICE.  Not my problem.
Comment 7 Filip Pizlo 2013-10-01 16:29:21 PDT 
Landed in http://trac.webkit.org/changeset/156747