Bug 122139 - Build fix for EFL, Qt, Gtk port after r156688
Summary: Build fix for EFL, Qt, Gtk port after r156688
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks: 122136
  Show dependency tree / graph
 
Reported: 2013-09-30 22:32 PDT by Ryuan Choi
Modified: 2013-10-01 03:55 PDT (History)
10 users (show)

See Also:

Attachments
Patch (13.22 KB, patch)
2013-09-30 22:33 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (13.33 KB, patch)
2013-09-30 22:53 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (16.24 KB, patch)
2013-09-30 23:13 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (17.17 KB, patch)
2013-09-30 23:26 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2013-09-30 22:32:04 PDT 
While removing Some OwnPtr and PassOwnPtr, some port specific methods are not renamed.
Comment 1 Ryuan Choi 2013-09-30 22:33:51 PDT 
Created attachment 213056 [details]
Patch
Comment 2 Anders Carlsson 2013-09-30 22:35:08 PDT 
Comment on attachment 213056 [details]
Patch

Thanks for fixing!
Comment 3 Early Warning System Bot 2013-09-30 22:48:17 PDT 
Comment on attachment 213056 [details]
Patch

Attachment 213056 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/2920003
Comment 4 Ryuan Choi 2013-09-30 22:53:50 PDT 
Created attachment 213058 [details]
Patch
Comment 5 Ryuan Choi 2013-09-30 23:13:22 PDT 
Created attachment 213059 [details]
Patch
Comment 6 WebKit Commit Bot 2013-09-30 23:14:56 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 7 Ryuan Choi 2013-09-30 23:26:03 PDT 
Created attachment 213060 [details]
Patch
Comment 8 Ryuan Choi 2013-09-30 23:36:37 PDT 
Committed r156700: <http://trac.webkit.org/changeset/156700>
Comment 9 Ryuan Choi 2013-09-30 23:38:41 PDT 
Comment on attachment 213060 [details]
Patch

Clearing flags.
I fixed build break on qt, gtk-wk2, efl-wk2.
(efl bot looks insane, now)

Hopefully, qt-wk2 will be also fixed.