Bug 122136 - Get rid of more uses of OwnPtr and PassOwnPtr
Summary: Get rid of more uses of OwnPtr and PassOwnPtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 122139 122153
Blocks:
  Show dependency tree / graph
 
Reported: 2013-09-30 17:43 PDT by Anders Carlsson
Modified: 2013-10-01 03:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (107.29 KB, patch)
2013-09-30 17:50 PDT, Anders Carlsson 		koivisto: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-09-30 17:43:51 PDT 
Get rid of more uses of OwnPtr and PassOwnPtr
Comment 1 Anders Carlsson 2013-09-30 17:50:04 PDT 
Created attachment 213047 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-30 17:52:19 PDT 
Attachment 213047 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/websockets/WebSocket.cpp', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/fileapi/Blob.cpp', u'Source/WebCore/fileapi/Blob.h', u'Source/WebCore/fileapi/File.cpp', u'Source/WebCore/fileapi/ThreadableBlobRegistry.cpp', u'Source/WebCore/fileapi/ThreadableBlobRegistry.h', u'Source/WebCore/fileapi/WebKitBlobBuilder.cpp', u'Source/WebCore/platform/network/BlobData.cpp', u'Source/WebCore/platform/network/BlobData.h', u'Source/WebCore/platform/network/BlobRegistry.h', u'Source/WebCore/platform/network/BlobRegistryImpl.cpp', u'Source/WebCore/platform/network/BlobRegistryImpl.h', u'Source/WebCore/xml/XMLHttpRequest.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/NetworkProcess/AsynchronousNetworkLoaderClient.h', u'Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp', u'Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/NetworkProcess/SynchronousNetworkLoaderClient.h', u'Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.mm', u'Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.h', u'Source/WebKit2/Platform/CoreIPC/MessageDecoder.cpp', u'Source/WebKit2/Platform/CoreIPC/MessageDecoder.h', u'Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp', u'Source/WebKit2/Platform/CoreIPC/mac/ImportanceAssertion.h', u'Source/WebKit2/Platform/mac/LayerHostingContext.h', u'Source/WebKit2/Platform/mac/LayerHostingContext.mm', u'Source/WebKit2/PluginProcess/PluginControllerProxy.cpp', u'Source/WebKit2/PluginProcess/PluginControllerProxy.h', u'Source/WebKit2/PluginProcess/WebProcessConnection.cpp', u'Source/WebKit2/PluginProcess/WebProcessConnection.h', u'Source/WebKit2/Shared/API/c/cg/WKImageCG.cpp', u'Source/WebKit2/Shared/BlockingResponseMap.h', u'Source/WebKit2/Shared/Downloads/Download.cpp', u'Source/WebKit2/Shared/Downloads/Download.h', u'Source/WebKit2/Shared/Downloads/DownloadManager.cpp', u'Source/WebKit2/Shared/FileAPI/BlobRegistrationData.cpp', u'Source/WebKit2/Shared/FileAPI/BlobRegistrationData.h', u'Source/WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp', u'Source/WebKit2/Shared/Plugins/NPObjectMessageReceiver.h', u'Source/WebKit2/Shared/Plugins/NPRemoteObjectMap.cpp', u'Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.cpp', u'Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.h', u'Source/WebKit2/Shared/ShareableBitmap.h', u'Source/WebKit2/Shared/WebURL.h', u'Source/WebKit2/Shared/cg/ShareableBitmapCG.cpp', u'Source/WebKit2/Shared/mac/SecItemShim.cpp', u'Source/WebKit2/UIProcess/API/mac/FindIndicatorWindow.h', u'Source/WebKit2/UIProcess/API/mac/PageClientImpl.h', u'Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm', u'Source/WebKit2/UIProcess/API/mac/WKView.mm', u'Source/WebKit2/UIProcess/API/mac/WKViewInternal.h', u'Source/WebKit2/UIProcess/BackingStore.cpp', u'Source/WebKit2/UIProcess/BackingStore.h', u'Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp', u'Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h', u'Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm', u'Source/WebKit2/UIProcess/PageClient.h', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h', u'Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm', u'Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h', u'Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp', u'Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.h', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm', u'Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h', u'Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm', u'Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm', u'Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp', u'Source/WebKit2/WebProcess/WebPage/DrawingArea.h', u'Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp', u'Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.h', u'Source/WebKit2/WebProcess/WebPage/FindController.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.h', u'Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.h', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.h', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm']" exit_code: 1
Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:50:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h:50:  Missing spaces around >>  [whitespace/operators] [3]
Total errors found: 2 in 78 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2013-09-30 17:57:01 PDT 
Comment on attachment 213047 [details]
Patch

Attachment 213047 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2854004
Comment 4 Anders Carlsson 2013-09-30 17:58:22 PDT 
Committed r156688: <http://trac.webkit.org/changeset/156688>
Comment 5 Csaba Osztrogonác 2013-10-01 01:57:22 PDT 
(In reply to comment #4)
> Committed r156688: <http://trac.webkit.org/changeset/156688>

buldfixes landed in:
- http://trac.webkit.org/changeset/156691 (Windows)
- http://trac.webkit.org/changeset/156700 (EFL,GTK,Qt)