Bug 122026 - Don't retry failures on Apple MountainLion Release WK1 tester
Summary: Don't retry failures on Apple MountainLion Release WK1 tester
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on: 122023
Blocks:
  Show dependency tree / graph
 
Reported: 2013-09-27 11:25 PDT by Alexey Proskuryakov
Modified: 2013-09-27 13:47 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (1.53 KB, patch)
2013-09-27 11:29 PDT, Alexey Proskuryakov 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-09-27 11:25:24 PDT 
There are no flaky tests on this bot now, and if we introduce any, we should be told about that in RED.
Comment 1 Alexey Proskuryakov 2013-09-27 11:29:35 PDT 
Created attachment 212827 [details]
proposed patch

There is a potential downside to this change - run-webkit-tests forces pixel testing when retrying, so it provides pixel results for tests that failed both times. But forcing pixel tests changes a lot anyway, so I'm not sure if those pixel results were more useful or misleading.
Comment 2 Mark Rowe (bdash) 2013-09-27 13:29:56 PDT 
Comment on attachment 212827 [details]
proposed patch

Looks fine except for the obvious typo: --no-retry-faiures. Please fix that before landing.
Comment 3 Alexey Proskuryakov 2013-09-27 13:47:29 PDT 
Committed <http://trac.webkit.org/r156571>.