Bug 122023 - Don't hardcode builder specific configuration in buildbot master.cfg
Summary: Don't hardcode builder specific configuration in buildbot master.cfg
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks: 122026
  Show dependency tree / graph
 
Reported: 2013-09-27 10:56 PDT by Alexey Proskuryakov
Modified: 2013-09-27 15:07 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (3.13 KB, patch)
2013-09-27 10:59 PDT, Alexey Proskuryakov 		mrowe: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (1.08 MB, application/zip)
2013-09-27 12:18 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-09-27 10:56:47 PDT 
Qt Mountain Lion Release is hardcoded to use -p argument in master.cfg. But this is what we have config.json for.
Comment 1 Alexey Proskuryakov 2013-09-27 10:59:43 PDT 
Created attachment 212825 [details]
proposed patch
Comment 2 Build Bot 2013-09-27 12:18:10 PDT 
Comment on attachment 212825 [details]
proposed patch

Attachment 212825 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/2654182

New failing tests:
media/track/track-cue-rendering-vertical.html
Comment 3 Build Bot 2013-09-27 12:18:11 PDT 
Created attachment 212832 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 4 Lucas Forschler 2013-09-27 12:44:53 PDT 
This change to the master could not affect the layout tests, so the below failure is bogus.
I think this is ok to land, but I don't have R+ powers.
Comment 5 Lucas Forschler 2013-09-27 12:45:37 PDT 
To clarify my previous comment, this change CAN affect layout tests when it's landed on the master, and the master is restarted.  However, the EWS bots do not consume this change.
Comment 6 Alexey Proskuryakov 2013-09-27 13:46:35 PDT 
Committed <http://trac.webkit.org/r156570>.
Comment 7 Lucas Forschler 2013-09-27 15:07:41 PDT 
Support patch committed in revision 156579.