Bug 121936 - Move m_style to RenderElement
Summary: Move m_style to RenderElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-25 20:57 PDT by Antti Koivisto
Modified: 2013-10-17 17:31 PDT (History)
9 users (show)

See Also:


Attachments
for bots (39.69 KB, patch)
2013-09-25 21:24 PDT, Antti Koivisto
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
another (42.56 KB, patch)
2013-09-25 22:27 PDT, Antti Koivisto
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (723.27 KB, application/zip)
2013-09-25 23:25 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (732.77 KB, application/zip)
2013-09-25 23:43 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (734.13 KB, application/zip)
2013-09-26 00:41 PDT, Build Bot
no flags Details
patch (49.71 KB, patch)
2013-09-26 17:56 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff
include WebKit changes too (50.53 KB, patch)
2013-09-26 18:23 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-09-25 20:57:44 PDT
Text renderers always have the same style as their parent.
Comment 1 Antti Koivisto 2013-09-25 21:24:53 PDT
Created attachment 212661 [details]
for bots
Comment 2 Early Warning System Bot 2013-09-25 21:32:49 PDT
Comment on attachment 212661 [details]
for bots

Attachment 212661 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/2230134
Comment 3 Early Warning System Bot 2013-09-25 21:34:36 PDT
Comment on attachment 212661 [details]
for bots

Attachment 212661 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2186147
Comment 4 Antti Koivisto 2013-09-25 22:27:32 PDT
Created attachment 212666 [details]
another
Comment 5 WebKit Commit Bot 2013-09-25 22:28:33 PDT
Attachment 212666 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/dom/PseudoElement.cpp', u'Source/WebCore/editing/ApplyBlockElementCommand.cpp', u'Source/WebCore/editing/HTMLInterchange.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderButton.cpp', u'Source/WebCore/rendering/RenderCombineText.cpp', u'Source/WebCore/rendering/RenderElement.cpp', u'Source/WebCore/rendering/RenderElement.h', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp', u'Source/WebCore/rendering/style/ContentData.cpp', u'Source/WebCore/style/StyleResolveTree.cpp', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm']" exit_code: 1
Source/WebCore/rendering/RenderImageResource.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Build Bot 2013-09-25 23:25:19 PDT
Comment on attachment 212666 [details]
another

Attachment 212666 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/2327002

New failing tests:
svg/custom/text-ctm.svg
svg/custom/SVGPoint-matrixTransform.svg
fast/text/decorations-with-text-combine.html
compositing/contents-opaque/visibility-hidden.html
svg/custom/text-hit-test.svg
svg/custom/getTransformToElement.svg
compositing/contents-opaque/hidden-with-visible-text.html
svg/text/append-text-node-to-tspan.html
Comment 7 Build Bot 2013-09-25 23:25:21 PDT
Created attachment 212669 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 Build Bot 2013-09-25 23:43:12 PDT
Comment on attachment 212666 [details]
another

Attachment 212666 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/2169254

New failing tests:
svg/custom/text-ctm.svg
svg/custom/SVGPoint-matrixTransform.svg
fast/text/decorations-with-text-combine.html
compositing/contents-opaque/visibility-hidden.html
svg/custom/text-hit-test.svg
svg/custom/getTransformToElement.svg
compositing/contents-opaque/hidden-with-visible-text.html
svg/text/append-text-node-to-tspan.html
Comment 9 Build Bot 2013-09-25 23:43:14 PDT
Created attachment 212670 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 10 Build Bot 2013-09-26 00:41:52 PDT
Comment on attachment 212666 [details]
another

Attachment 212666 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/2340008

New failing tests:
svg/custom/text-ctm.svg
svg/custom/SVGPoint-matrixTransform.svg
fast/text/decorations-with-text-combine.html
compositing/contents-opaque/visibility-hidden.html
svg/custom/text-hit-test.svg
svg/custom/getTransformToElement.svg
compositing/contents-opaque/hidden-with-visible-text.html
svg/text/append-text-node-to-tspan.html
Comment 11 Build Bot 2013-09-26 00:41:54 PDT
Created attachment 212673 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 12 Antti Koivisto 2013-09-26 17:56:24 PDT
Created attachment 212776 [details]
patch
Comment 13 Andreas Kling 2013-09-26 18:13:13 PDT
Comment on attachment 212776 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212776&action=review

This looks great to me!

> Source/WebCore/ChangeLog:66
> +            Change assert. This can get legitimely called during layout for first letter renderers.

Typo, legitimately

> LayoutTests/ChangeLog:8
> +        Progressions from text style updating correctly in all cases.

I'm gonna take your word for this.
Comment 14 Antti Koivisto 2013-09-26 18:23:35 PDT
Created attachment 212779 [details]
include WebKit changes too
Comment 15 Antti Koivisto 2013-09-26 19:01:37 PDT
https://trac.webkit.org/r156527
Comment 17 Roger Fong 2013-10-17 16:09:37 PDT
Just noticed that the following test is failing on Windows:
fast\forms\button-first-line-first-letter.html

Assertion failure:     ASSERT(innerStyle->refCount() == 1);

>	WebKit.dll!WebCore::RenderButton::setupInnerStyle(WebCore::RenderStyle * innerStyle)  Line 129	C++
 	WebKit.dll!WebCore::RenderButton::styleDidChange(WebCore::StyleDifference diff, const WebCore::RenderStyle * oldStyle)  Line 111	C++
 	WebKit.dll!WebCore::RenderElement::setStyle(WTF::PassRefPtr<WebCore::RenderStyle> style)  Line 398	C++
 	WebKit.dll!WebCore::RenderElement::setAnimatableStyle(WTF::PassRefPtr<WebCore::RenderStyle> style)  Line 436	C++
 	WebKit.dll!WebCore::Style::resolveLocal(WebCore::Element & current, WebCore::Style::Change inheritedChange)  Line 604 + 0x19 bytes	C++
 	WebKit.dll!WebCore::Style::resolveTree(WebCore::Element & current, WebCore::Style::Change change)  Line 740 + 0xd bytes	C++
 	WebKit.dll!WebCore::Style::resolveTree(WebCore::Element & current, WebCore::Style::Change change)  Line 772 + 0xd bytes	C++
 	WebKit.dll!WebCore::Style::resolveTree(WebCore::Element & current, WebCore::Style::Change change)  Line 772 + 0xd bytes	C++
 	WebKit.dll!WebCore::Style::resolveTree(WebCore::Document & document, WebCore::Style::Change change)  Line 812 + 0xd bytes	C++
 	WebKit.dll!WebCore::Document::recalcStyle(WebCore::Style::Change change)  Line 1729 + 0xd bytes	C++
Comment 18 Darin Adler 2013-10-17 16:34:09 PDT
Lets make a new bug report about that Windows test failure. We should diagnose and fix it!
Comment 19 Roger Fong 2013-10-17 17:31:37 PDT
Filed https://bugs.webkit.org/show_bug.cgi?id=123005 for the Windows failure.