NEW 123005
[Windows] button-first-line-first-letter fails after r156527 
https://bugs.webkit.org/show_bug.cgi?id=123005
Summary [Windows] button-first-line-first-letter fails after r156527
Roger Fong
Reported 2013-10-17 17:29:58 PDT
fast\forms\button-first-line-first-letter.html Assertion failure: ASSERT(innerStyle->refCount() == 1); > WebKit.dll!WebCore::RenderButton::setupInnerStyle(WebCore::RenderStyle * innerStyle) Line 129 C++ WebKit.dll!WebCore::RenderButton::styleDidChange(WebCore::StyleDifference diff, const WebCore::RenderStyle * oldStyle) Line 111 C++ WebKit.dll!WebCore::RenderElement::setStyle(WTF::PassRefPtr<WebCore::RenderStyle> style) Line 398 C++ WebKit.dll!WebCore::RenderElement::setAnimatableStyle(WTF::PassRefPtr<WebCore::RenderStyle> style) Line 436 C++ WebKit.dll!WebCore::Style::resolveLocal(WebCore::Element & current, WebCore::Style::Change inheritedChange) Line 604 + 0x19 bytes C++ WebKit.dll!WebCore::Style::resolveTree(WebCore::Element & current, WebCore::Style::Change change) Line 740 + 0xd bytes C++ WebKit.dll!WebCore::Style::resolveTree(WebCore::Element & current, WebCore::Style::Change change) Line 772 + 0xd bytes C++ WebKit.dll!WebCore::Style::resolveTree(WebCore::Element & current, WebCore::Style::Change change) Line 772 + 0xd bytes C++ WebKit.dll!WebCore::Style::resolveTree(WebCore::Document & document, WebCore::Style::Change change) Line 812 + 0xd bytes C++ WebKit.dll!WebCore::Document::recalcStyle(WebCore::Style::Change change) Line 1729 + 0xd bytes C++ The following .letter::first-letter { color: green; } is causing the problem.
Attachments
Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2013-10-17 17:32:56 PDT
The refcount is 2 instead of 1. I'm also noticing that the RenderStyle passed to setAnimatableStyle(WTF::PassRefPtr<WebCore::RenderStyle> style) Line 436 C++ has a refcoutn of 3. When the test is working it has a count of 4.
Ahmad Saleem
Comment 2 2024-05-17 11:39:03 PDT
AppleWin port is gone and we don't have any platform specific expectation for all platforms (including win-cairo) as well [confirmed via 'searchfox.org' (wubkat)] port. Although I am not sure whether `win-cairo` port is Debug port or not and whether it triggers 'assert' or not. CCing - Fuji & Don for their input. Want to close old bugs. :-)
Note You need to log in before you can comment on or make changes to this bug.