RESOLVED FIXED 121716
Remove includes from LineWidth.h 
https://bugs.webkit.org/show_bug.cgi?id=121716
Summary Remove includes from LineWidth.h
Zoltan Horvath
Reported 2013-09-20 14:09:46 PDT
In r156197 I removed logicalLineHeight from LineWIdth.h, so we don't need to include RenderBlock.h and RenderRubyRun.h anymore in LineWidth.h.
Attachments
proposed patch (1.79 KB, patch)
2013-09-20 14:24 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
proposed patch (1.77 KB, patch)
2013-09-20 14:45 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2013-09-20 14:24:21 PDT
Created attachment 212217 [details] proposed patch
Early Warning System Bot
Comment 2 2013-09-20 14:29:33 PDT
Comment on attachment 212217 [details] proposed patch Attachment 212217 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/2030006
Early Warning System Bot
Comment 3 2013-09-20 14:30:17 PDT
Comment on attachment 212217 [details] proposed patch Attachment 212217 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/2033005
EFL EWS Bot
Comment 4 2013-09-20 14:32:40 PDT
Comment on attachment 212217 [details] proposed patch Attachment 212217 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1865203
Zoltan Horvath
Comment 5 2013-09-20 14:45:01 PDT
Created attachment 212220 [details] proposed patch
Darin Adler
Comment 6 2013-09-20 20:08:48 PDT
Comment on attachment 212220 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=212220&action=review > Source/WebCore/rendering/LineWidth.h:38 > +struct LineSegment; Our normal style is to put struct forward declarations into a separate paragraph. I’ll still say cq+ though. No need to hold this up on such a small thing.
Zoltan Horvath
Comment 7 2013-09-20 20:28:28 PDT
(In reply to comment #6) > (From update of attachment 212220 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=212220&action=review > > > Source/WebCore/rendering/LineWidth.h:38 > > +struct LineSegment; > > Our normal style is to put struct forward declarations into a separate paragraph. I’ll still say cq+ though. No need to hold this up on such a small thing. It's good to know. Thanks for the review and the comment, I'll update it eventually, when I need to touch the code around the forward declarations.
WebKit Commit Bot
Comment 8 2013-09-20 20:35:51 PDT
Comment on attachment 212220 [details] proposed patch Clearing flags on attachment: 212220 Committed r156220: <http://trac.webkit.org/changeset/156220>
WebKit Commit Bot
Comment 9 2013-09-20 20:35:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.