Bug 121674 - [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
Summary: [ATK] Missing WTR AccessibilityController::addNotificationListener implementa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-20 06:03 PDT by Denis Nomiyama (dnomi)
Modified: 2013-09-24 07:23 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.65 KB, patch)
2013-09-20 08:52 PDT, Denis Nomiyama (dnomi) 		no flags Details | Formatted Diff | Diff
Patch (5.57 KB, patch)
2013-09-24 06:18 PDT, Denis Nomiyama (dnomi) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Nomiyama (dnomi) 2013-09-20 06:03:58 PDT 
AccessibilityController of WTR in the GTK+ port is missing global event notification implementation.
Comment 1 Denis Nomiyama (dnomi) 2013-09-20 08:52:21 PDT 
Created attachment 212173 [details]
Patch
Comment 2 Mario Sanchez Prada 2013-09-24 05:43:28 PDT 
Comment on attachment 212173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212173&action=review

The patch is great, just r- because of the EFL bit, which I think it's better to leave it to the EFL guys (so they can test it first)

> Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:100
> +#if !PLATFORM(GTK) && !PLATFORM(EFL) && !PLATFORM(MAC)

Unless you are sure about this working on EFL, I think it's probably better to live the EFL check out of this patch and let the EFL guys (Krzysztof) know about the change with a comment in bug 112003, where they track the issue about the same failing test, buyt for EFL-WK2
Comment 3 Denis Nomiyama (dnomi) 2013-09-24 05:48:53 PDT 
Comment on attachment 212173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212173&action=review

Thanks for the review. I will modify the patch accordingly.

>> Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:100
>> +#if !PLATFORM(GTK) && !PLATFORM(EFL) && !PLATFORM(MAC)
> 
> Unless you are sure about this working on EFL, I think it's probably better to live the EFL check out of this patch and let the EFL guys (Krzysztof) know about the change with a comment in bug 112003, where they track the issue about the same failing test, buyt for EFL-WK2

Sure. I'll change the patch and will add a comment to 112003.
Comment 4 Denis Nomiyama (dnomi) 2013-09-24 06:18:43 PDT 
Created attachment 212458 [details]
Patch

Modified the patch according to review comments.
Comment 5 Mario Sanchez Prada 2013-09-24 07:17:09 PDT 
Comment on attachment 212458 [details]
Patch

thanks!
Comment 6 WebKit Commit Bot 2013-09-24 07:22:57 PDT 
Comment on attachment 212458 [details]
Patch

Clearing flags on attachment: 212458

Committed r156332: <http://trac.webkit.org/changeset/156332>
Comment 7 WebKit Commit Bot 2013-09-24 07:23:00 PDT 
All reviewed patches have been landed.  Closing bug.