Bug 112003 - [EFL] accessibility/loading-iframe-sends-notification.html is failing
Summary: [EFL] accessibility/loading-iframe-sends-notification.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111985
  Show dependency tree / graph
 
Reported: 2013-03-11 07:25 PDT by Krzysztof Czech
Modified: 2013-09-25 04:01 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.73 KB, patch)
2013-09-25 01:31 PDT, Krzysztof Czech 		mario: review-
Details | Formatted Diff | Diff
Patch (6.65 KB, patch)
2013-09-25 02:14 PDT, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Czech 2013-03-11 07:25:49 PDT 
accessibility/loading-iframe-sends-notification.html is failing on all EFL platforms.
Comment 1 Denis Nomiyama (dnomi) 2013-09-24 07:30:06 PDT 
Hi, this issue has been fixed on the GTK port, both on WebKit1 (bug 98370) and WebKit2 (bug 121674).

For the EFL port to work, please enable the EFL guards in the following files:

- Source/WebCore/dom/Document.cpp at Document::implicitClose()
  To send notifications for AXObjectCache::AXLayoutComplete.

- Source/WebCore/page/FrameView.cpp at FrameView::layout()
  To send notifications for AXObjectCache::AXLayoutComplete.
  
- Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp
  To disable stub implementations of addNotificationListener() and removeNotificationListener().

- Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp
  To enable actual implementations of addNotificationListener() and removeNotificationListener() for ATK.
Comment 2 Krzysztof Czech 2013-09-24 07:43:14 PDT 
Hi, I've already noticed this issue has been fixed. I will propose a patch.

Thanks.
Comment 3 Krzysztof Czech 2013-09-25 01:31:59 PDT 
Created attachment 212541 [details]
Patch
Comment 4 Mario Sanchez Prada 2013-09-25 01:45:18 PDT 
Comment on attachment 212541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212541&action=review

> Source/WebCore/dom/Document.cpp:2487
> +#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))

There are dummy implementations in AXObjectCache if !HAVE(ACCESSIBILITY), so you do not need to add that condition there. Just adding "|| PLATFORM(EFL)" should be enough

> Source/WebCore/page/FrameView.cpp:1328
> +#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))

Ditto.
Comment 5 Krzysztof Czech 2013-09-25 02:14:04 PDT 
Created attachment 212544 [details]
Patch
Comment 6 Krzysztof Czech 2013-09-25 02:15:03 PDT 
> > Source/WebCore/dom/Document.cpp:2487
> > +#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))
> 
> There are dummy implementations in AXObjectCache if !HAVE(ACCESSIBILITY), so you do not need to add that condition there. Just adding "|| PLATFORM(EFL)" should be enough
> 
> > Source/WebCore/page/FrameView.cpp:1328
> > +#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))
> 
> Ditto.

Indeed, corrected.
Thanks
Comment 7 Mario Sanchez Prada 2013-09-25 03:37:44 PDT 
Comment on attachment 212544 [details]
Patch

thanks
Comment 8 WebKit Commit Bot 2013-09-25 04:01:13 PDT 
Comment on attachment 212544 [details]
Patch

Clearing flags on attachment: 212544

Committed r156386: <http://trac.webkit.org/changeset/156386>
Comment 9 WebKit Commit Bot 2013-09-25 04:01:16 PDT 
All reviewed patches have been landed.  Closing bug.