Bug 112003 – [EFL] accessibility/loading-iframe-sends-notification.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Krzysztof Czech]

accessibility/loading-iframe-sends-notification.html is failing on all EFL platforms.

[Denis Nomiyama (dnomi)]

Hi, this issue has been fixed on the GTK port, both on WebKit1 (bug 98370) and WebKit2 (bug 121674).

For the EFL port to work, please enable the EFL guards in the following files:

- Source/WebCore/dom/Document.cpp at Document::implicitClose()
  To send notifications for AXObjectCache::AXLayoutComplete.

- Source/WebCore/page/FrameView.cpp at FrameView::layout()
  To send notifications for AXObjectCache::AXLayoutComplete.
  
- Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp
  To disable stub implementations of addNotificationListener() and removeNotificationListener().

- Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp
  To enable actual implementations of addNotificationListener() and removeNotificationListener() for ATK.

[Krzysztof Czech]

Hi, I've already noticed this issue has been fixed. I will propose a patch.

Thanks.

[Krzysztof Czech]

Created attachment 212541 [details]
Patch

[Mario Sanchez Prada]

Comment on attachment 212541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212541&action=review

> Source/WebCore/dom/Document.cpp:2487
> +#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))

There are dummy implementations in AXObjectCache if !HAVE(ACCESSIBILITY), so you do not need to add that condition there. Just adding "|| PLATFORM(EFL)" should be enough

> Source/WebCore/page/FrameView.cpp:1328
> +#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))

Ditto.

[Krzysztof Czech]

Created attachment 212544 [details]
Patch

[Krzysztof Czech]

> > Source/WebCore/dom/Document.cpp:2487
> > +#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))
> 
> There are dummy implementations in AXObjectCache if !HAVE(ACCESSIBILITY), so you do not need to add that condition there. Just adding "|| PLATFORM(EFL)" should be enough
> 
> > Source/WebCore/page/FrameView.cpp:1328
> > +#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))
> 
> Ditto.

Indeed, corrected.
Thanks

[Mario Sanchez Prada]

Comment on attachment 212544 [details]
Patch

thanks

[WebKit Commit Bot]

Comment on attachment 212544 [details]
Patch

Clearing flags on attachment: 212544

Committed r156386: <http://trac.webkit.org/changeset/156386>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.