RESOLVED FIXED Bug 121584
MediaStream API: update NavigatorUserMediaError object to match spec 
https://bugs.webkit.org/show_bug.cgi?id=121584
Summary MediaStream API: update NavigatorUserMediaError object to match spec
Eric Carlson
Reported 2013-09-18 20:00:28 PDT
NavigatorUserMediaError should inherit from DOMError, should not have a "message" attribute.
Attachments
Proposed patch (24.54 KB, patch)
2013-09-18 21:44 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Updated patch (24.54 KB, patch)
2013-09-19 07:02 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2013-09-18 20:00:45 PDT
<rdar://problem/15022765>
Eric Carlson
Comment 2 2013-09-18 21:44:09 PDT
Created attachment 212034 [details] Proposed patch
WebKit Commit Bot
Comment 3 2013-09-18 21:47:04 PDT
Attachment 212034 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/mediastream/getusermedia-expected.txt', u'LayoutTests/fast/mediastream/getusermedia.html', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/mediastream/NavigatorUserMediaError.cpp', u'Source/WebCore/Modules/mediastream/NavigatorUserMediaError.h', u'Source/WebCore/Modules/mediastream/NavigatorUserMediaError.idl', u'Source/WebCore/Modules/mediastream/UserMediaRequest.cpp', u'Source/WebCore/Modules/mediastream/UserMediaRequest.h', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/dom/DOMError.h', u'Source/WebCore/platform/mediastream/MediaStreamSourcesQueryClient.h']" exit_code: 1 Source/WebCore/Modules/mediastream/NavigatorUserMediaError.cpp:30: You should add a blank line after implementation file's own header. [build/include_order] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Carlson
Comment 4 2013-09-18 21:52:24 PDT
(In reply to comment #3) > Attachment 212034 [details] did not pass style-queue: > > Source/WebCore/Modules/mediastream/NavigatorUserMediaError.cpp:30: You should add a blank line after implementation file's own header. [build/include_order] [4] Oh the horror!
Eric Carlson
Comment 5 2013-09-19 07:02:51 PDT
Created attachment 212064 [details] Updated patch
Dean Jackson
Comment 6 2013-09-19 10:37:31 PDT
Comment on attachment 212064 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=212064&action=review > Source/WebCore/Modules/mediastream/UserMediaRequest.h:68 > + virtual PassRefPtr<MediaConstraints> videoConstraints() const OVERRIDE; Nit: two spaces before OVERRIDE > Source/WebCore/Modules/mediastream/UserMediaRequest.h:69 > + virtual void didCompleteQuery(const MediaStreamSourceVector& audioSources, const MediaStreamSourceVector& videoSources) OVERRIDE; Here too.
Eric Carlson
Comment 7 2013-09-19 12:06:20 PDT
Committed r156108: https://trac.webkit.org/r156108
Eric Carlson
Comment 8 2013-09-26 17:10:59 PDT
*** Bug 121404 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.