Bug 121466 - CTTE: InputType should store its HTMLInputElement back pointer as a reference
Summary: CTTE: InputType should store its HTMLInputElement back pointer as a reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
: 121401 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-09-16 20:03 PDT by Sam Weinig
Modified: 2013-09-16 23:32 PDT (History)
2 users (show)

See Also:

Attachments
Patch (133.35 KB, patch)
2013-09-16 20:06 PDT, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-09-16 20:03:25 PDT 
CTTE: InputType should store its HTMLInputElement back pointer as a reference
Comment 1 Sam Weinig 2013-09-16 20:06:39 PDT 
Created attachment 211859 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-16 20:08:40 PDT 
Attachment 211859 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/accessibility/AccessibilitySlider.cpp', u'Source/WebCore/html/BaseButtonInputType.cpp', u'Source/WebCore/html/BaseButtonInputType.h', u'Source/WebCore/html/BaseCheckableInputType.cpp', u'Source/WebCore/html/BaseCheckableInputType.h', u'Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp', u'Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h', u'Source/WebCore/html/BaseClickableWithKeyInputType.cpp', u'Source/WebCore/html/BaseClickableWithKeyInputType.h', u'Source/WebCore/html/BaseDateAndTimeInputType.cpp', u'Source/WebCore/html/BaseDateAndTimeInputType.h', u'Source/WebCore/html/BaseTextInputType.cpp', u'Source/WebCore/html/BaseTextInputType.h', u'Source/WebCore/html/ButtonInputType.cpp', u'Source/WebCore/html/ButtonInputType.h', u'Source/WebCore/html/CheckboxInputType.cpp', u'Source/WebCore/html/CheckboxInputType.h', u'Source/WebCore/html/ColorInputType.cpp', u'Source/WebCore/html/ColorInputType.h', u'Source/WebCore/html/DateInputType.cpp', u'Source/WebCore/html/DateInputType.h', u'Source/WebCore/html/DateTimeInputType.cpp', u'Source/WebCore/html/DateTimeInputType.h', u'Source/WebCore/html/DateTimeLocalInputType.cpp', u'Source/WebCore/html/DateTimeLocalInputType.h', u'Source/WebCore/html/EmailInputType.cpp', u'Source/WebCore/html/EmailInputType.h', u'Source/WebCore/html/FileInputType.cpp', u'Source/WebCore/html/FileInputType.h', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HiddenInputType.cpp', u'Source/WebCore/html/HiddenInputType.h', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/ImageInputType.h', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/InputType.h', u'Source/WebCore/html/MonthInputType.cpp', u'Source/WebCore/html/MonthInputType.h', u'Source/WebCore/html/NumberInputType.cpp', u'Source/WebCore/html/NumberInputType.h', u'Source/WebCore/html/PasswordInputType.cpp', u'Source/WebCore/html/PasswordInputType.h', u'Source/WebCore/html/RadioInputType.cpp', u'Source/WebCore/html/RadioInputType.h', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/RangeInputType.h', u'Source/WebCore/html/ResetInputType.cpp', u'Source/WebCore/html/ResetInputType.h', u'Source/WebCore/html/SearchInputType.cpp', u'Source/WebCore/html/SearchInputType.h', u'Source/WebCore/html/SubmitInputType.cpp', u'Source/WebCore/html/SubmitInputType.h', u'Source/WebCore/html/TelephoneInputType.cpp', u'Source/WebCore/html/TelephoneInputType.h', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/TextFieldInputType.h', u'Source/WebCore/html/TextInputType.cpp', u'Source/WebCore/html/TextInputType.h', u'Source/WebCore/html/TimeInputType.cpp', u'Source/WebCore/html/TimeInputType.h', u'Source/WebCore/html/URLInputType.cpp', u'Source/WebCore/html/URLInputType.h', u'Source/WebCore/html/WeekInputType.cpp', u'Source/WebCore/html/WeekInputType.h', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.h', u'Source/WebCore/rendering/RenderSlider.cpp']" exit_code: 1
Source/WebCore/html/InputType.cpp:142:  Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Total errors found: 1 in 68 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2013-09-16 21:20:59 PDT 
Committed r155928: <http://trac.webkit.org/changeset/155928>
Comment 4 Andreas Kling 2013-09-16 23:32:40 PDT 
*** Bug 121401 has been marked as a duplicate of this bug. ***