Bug 121401 - CTTE: InputType element backpointer should be a reference.
Summary: CTTE: InputType element backpointer should be a reference.
Status: RESOLVED DUPLICATE of bug 121466
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-15 13:25 PDT by Andreas Kling
Modified: 2013-09-16 23:32 PDT (History)
5 users (show)

See Also:

Attachments
Patch (106.58 KB, patch)
2013-09-15 13:27 PDT, Andreas Kling 		koivisto: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-15 13:25:23 PDT 
CTTE: InputType element backpointer should be a reference.
Comment 1 Andreas Kling 2013-09-15 13:27:53 PDT 
Created attachment 211727 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-15 14:18:33 PDT 
Attachment 211727 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/html/BaseButtonInputType.cpp', u'Source/WebCore/html/BaseButtonInputType.h', u'Source/WebCore/html/BaseCheckableInputType.cpp', u'Source/WebCore/html/BaseCheckableInputType.h', u'Source/WebCore/html/BaseClickableWithKeyInputType.cpp', u'Source/WebCore/html/BaseClickableWithKeyInputType.h', u'Source/WebCore/html/BaseTextInputType.cpp', u'Source/WebCore/html/BaseTextInputType.h', u'Source/WebCore/html/ButtonInputType.cpp', u'Source/WebCore/html/ButtonInputType.h', u'Source/WebCore/html/CheckboxInputType.cpp', u'Source/WebCore/html/CheckboxInputType.h', u'Source/WebCore/html/ColorInputType.cpp', u'Source/WebCore/html/ColorInputType.h', u'Source/WebCore/html/EmailInputType.cpp', u'Source/WebCore/html/EmailInputType.h', u'Source/WebCore/html/FileInputType.cpp', u'Source/WebCore/html/FileInputType.h', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HiddenInputType.cpp', u'Source/WebCore/html/HiddenInputType.h', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/ImageInputType.h', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/InputType.h', u'Source/WebCore/html/NumberInputType.cpp', u'Source/WebCore/html/NumberInputType.h', u'Source/WebCore/html/PasswordInputType.cpp', u'Source/WebCore/html/PasswordInputType.h', u'Source/WebCore/html/RadioInputType.cpp', u'Source/WebCore/html/RadioInputType.h', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/RangeInputType.h', u'Source/WebCore/html/ResetInputType.cpp', u'Source/WebCore/html/ResetInputType.h', u'Source/WebCore/html/SearchInputType.cpp', u'Source/WebCore/html/SearchInputType.h', u'Source/WebCore/html/SubmitInputType.cpp', u'Source/WebCore/html/SubmitInputType.h', u'Source/WebCore/html/TelephoneInputType.cpp', u'Source/WebCore/html/TelephoneInputType.h', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/TextFieldInputType.h', u'Source/WebCore/html/TextInputType.cpp', u'Source/WebCore/html/TextInputType.h', u'Source/WebCore/html/URLInputType.cpp', u'Source/WebCore/html/URLInputType.h']" exit_code: 1
Source/WebCore/html/InputType.cpp:142:  Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Total errors found: 1 in 48 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2013-09-15 14:20:14 PDT 
Comment on attachment 211727 [details]
Patch

Attachment 211727 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1898047
Comment 4 EFL EWS Bot 2013-09-15 14:20:24 PDT 
Comment on attachment 211727 [details]
Patch

Attachment 211727 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1883121
Comment 5 EFL EWS Bot 2013-09-15 14:21:57 PDT 
Comment on attachment 211727 [details]
Patch

Attachment 211727 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1892169
Comment 6 Early Warning System Bot 2013-09-15 14:22:57 PDT 
Comment on attachment 211727 [details]
Patch

Attachment 211727 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1892170
Comment 7 Andreas Kling 2013-09-16 23:32:40 PDT 
heh

*** This bug has been marked as a duplicate of bug 121466 ***