Bug 121456 - Move the widow functions/members out of RenderBlock and into RenderBlockFlow.
Summary: Move the widow functions/members out of RenderBlock and into RenderBlockFlow.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 84924
  Show dependency treegraph
 
Reported: 2013-09-16 15:08 PDT by Dave Hyatt
Modified: 2013-09-17 09:40 PDT (History)
5 users (show)

See Also:


Attachments
Patch (29.37 KB, patch)
2013-09-16 15:08 PDT, Dave Hyatt
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2013-09-16 15:08:00 PDT
Move the widow functions/members out of RenderBlock and into RenderBlockFlow.
Comment 1 Dave Hyatt 2013-09-16 15:08:52 PDT
Created attachment 211835 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-16 15:11:28 PDT
Attachment 211835 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderObject.h']" exit_code: 1
Source/WebCore/rendering/RenderBlockFlow.cpp:1348:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlockFlow.cpp:1349:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlockFlow.cpp:1354:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlockFlow.cpp:1358:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2013-09-17 09:40:45 PDT
Landed in r155964.