Bug 121391 - Clean up WebSocket code and prevent it from dropping messages
Summary: Clean up WebSocket code and prevent it from dropping messages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
: 121315 (view as bug list)
Depends on:
Blocks: 121383
  Show dependency tree / graph
 
Reported: 2013-09-15 08:57 PDT by Timothy Hatcher
Modified: 2013-09-17 10:04 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.28 KB, patch)
2013-09-15 08:59 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (5.61 KB, patch)
2013-09-15 09:05 PDT, Timothy Hatcher 		joepeck: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-09-15 08:57:30 PDT 
Clean up WebSocket code and prevent it from dropping messages
Comment 1 Timothy Hatcher 2013-09-15 08:59:43 PDT 
Created attachment 211710 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2013-09-15 09:00:35 PDT 
<rdar://problem/14995089>
Comment 3 Timothy Hatcher 2013-09-15 09:00:49 PDT 
Roland, can you test this for me? It should fix the issue you emailed about.
Comment 4 Radar WebKit Bug Importer 2013-09-15 09:01:17 PDT 
<rdar://problem/14995091>
Comment 5 Timothy Hatcher 2013-09-15 09:05:14 PDT 
Created attachment 211711 [details]
Patch
Comment 6 Roland Takacs 2013-09-15 15:29:57 PDT 
It seems the appearance and the functionality are good, but there are some random WebProcess crashes.

Tomorrow I will determine what causes them.
Comment 7 Timothy Hatcher 2013-09-16 10:04:48 PDT 
*** Bug 121315 has been marked as a duplicate of this bug. ***
Comment 8 Timothy Hatcher 2013-09-16 10:10:31 PDT 
The crashes are likely not related.
Comment 9 Joseph Pecoraro 2013-09-16 11:02:49 PDT 
Comment on attachment 211711 [details]
Patch

r=me. It sounds like Roland Takacs tested it and it worked for him as well. But I'll let you cq it.
Comment 10 Joseph Pecoraro 2013-09-16 11:03:08 PDT 
Comment on attachment 211711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211711&action=review

> Source/WebInspectorUI/ChangeLog:13
> +        if the socket ins't ready yet. Call _sendPendingMessagesToBackendIfNeeded.

Typo: ins't
Comment 11 Roland Takacs 2013-09-16 14:05:11 PDT 
(In reply to comment #8)
> The crashes are likely not related.

Yes, as I checked the crash happens at ImageBufferCairo.cpp.
Comment 12 Timothy Hatcher 2013-09-17 10:03:51 PDT 
http://trac.webkit.org/changeset/155966