Bug 121383 - [GTK] Test /webkit2/WebKitWebInspectorServer/test-open-debugging-session times out after r155714
Summary: [GTK] Test /webkit2/WebKitWebInspectorServer/test-open-debugging-session time...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords: Gtk
Depends on: 121391
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-15 04:35 PDT by Carlos Garcia Campos
Modified: 2013-09-17 12:26 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.97 KB, patch)
2013-09-15 19:19 PDT, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-09-15 04:35:19 PDT
It started to fail (timeout) after the move to the new web inspector (I think)
Comment 1 Gustavo Noronha (kov) 2013-09-15 19:17:14 PDT
The timeout is caused by 121315, but I neglected this test and it needs fixage too, because one of its assumptions is no longer true. Patch incoming.
Comment 2 Gustavo Noronha (kov) 2013-09-15 19:19:12 PDT
Created attachment 211734 [details]
Patch
Comment 3 WebKit Commit Bot 2013-09-15 19:21:07 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Gustavo Noronha (kov) 2013-09-17 12:26:28 PDT
Comment on attachment 211734 [details]
Patch

Clearing flags on attachment: 211734

Committed r155985: <http://trac.webkit.org/changeset/155985>
Comment 5 Gustavo Noronha (kov) 2013-09-17 12:26:34 PDT
All reviewed patches have been landed.  Closing bug.