Bug 121323 - Make FloatingObjects own it's FloatingObject instances
Summary: Make FloatingObjects own it's FloatingObject instances
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-13 14:36 PDT by Bem Jones-Bey
Modified: 2014-10-27 13:31 PDT (History)
6 users (show)

See Also:

Attachments
Patch (19.80 KB, patch)
2013-09-13 16:10 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Patch (19.79 KB, patch)
2013-09-16 14:28 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Patch (19.80 KB, patch)
2013-09-16 14:30 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-09-13 14:36:42 PDT 
Make FloatingObjects own it's FloatingObject instances
Comment 1 Bem Jones-Bey 2013-09-13 16:10:50 PDT 
Created attachment 211598 [details]
Patch
Comment 2 Alexandru Chiculita 2013-09-13 16:46:48 PDT 
Comment on attachment 211598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211598&action=review

Looks good. Thanks!

> Source/WebCore/rendering/FloatingObjects.cpp:174
> +void FloatingObjects::exportToFloatInfoMap(RendererToFloatInfoMap& map)

nit: The function name is confusing as it doesn't say it is releasing the ownership of its own content.

> Source/WebCore/rendering/RenderBlock.cpp:3307
> +    m_floatingObjects->add(newObj.release());

nit: Might be usefull to make "add" return a pointer to the floating object to avoid the manual store on the stack.
Comment 3 Bem Jones-Bey 2013-09-16 14:28:28 PDT 
Created attachment 211831 [details]
Patch

rename export method and make FloatingObjects::add have a return value per review feedback.
Comment 4 Bem Jones-Bey 2013-09-16 14:30:10 PDT 
Created attachment 211832 [details]
Patch

Add reviewer name
Comment 5 WebKit Commit Bot 2013-09-16 15:00:37 PDT 
Comment on attachment 211832 [details]
Patch

Clearing flags on attachment: 211832

Committed r155906: <http://trac.webkit.org/changeset/155906>
Comment 6 WebKit Commit Bot 2013-09-16 15:00:39 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Philippe Wittenbergh 2013-09-17 20:10:04 PDT 
Did this cause bug 121532 ?
Comment 8 Bem Jones-Bey 2013-09-18 08:40:33 PDT 
(In reply to comment #7)
> Did this cause bug 121532 ?

It looks like it may have. I'm looking into it.
Comment 9 Simon Fraser (smfr) 2014-10-27 13:31:52 PDT 
This caused bug 138100.