Bug 121323 – Make FloatingObjects own it's FloatingObject instances

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Bem Jones-Bey]

Make FloatingObjects own it's FloatingObject instances

[Bem Jones-Bey]

Created attachment 211598 [details]
Patch

[Alexandru Chiculita]

Comment on attachment 211598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211598&action=review

Looks good. Thanks!

> Source/WebCore/rendering/FloatingObjects.cpp:174
> +void FloatingObjects::exportToFloatInfoMap(RendererToFloatInfoMap& map)

nit: The function name is confusing as it doesn't say it is releasing the ownership of its own content.

> Source/WebCore/rendering/RenderBlock.cpp:3307
> +    m_floatingObjects->add(newObj.release());

nit: Might be usefull to make "add" return a pointer to the floating object to avoid the manual store on the stack.

[Bem Jones-Bey]

Created attachment 211831 [details]
Patch

rename export method and make FloatingObjects::add have a return value per review feedback.

[Bem Jones-Bey]

Created attachment 211832 [details]
Patch

Add reviewer name

[WebKit Commit Bot]

Comment on attachment 211832 [details]
Patch

Clearing flags on attachment: 211832

Committed r155906: <http://trac.webkit.org/changeset/155906>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Philippe Wittenbergh]

Did this cause bug 121532 ?

[Bem Jones-Bey]

(In reply to comment #7)
> Did this cause bug 121532 ?

It looks like it may have. I'm looking into it.

[Simon Fraser (smfr)]

This caused bug 138100.