Bug 138100 – REGRESSION(r155906): Page content disappears on Tuaw article after loading

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Simon Fraser (smfr)]

When loading http://www.tuaw.com/2014/10/21/whats-apple-doing-with-the-ipad-mini-3/?ncid=rss_truncated in Safari 7.1 on Mavericks, after the page finishes loading, the main story disappears.

Resizing the window does not bring it back, but opening the inspector and toggling some style on a hidden element does cause it to render correctly.

[Simon Fraser (smfr)]

rdar://problem/18775249

[Bem Jones-Bey]

Created attachment 241960 [details]
More minimal test case

I spent some time yesterday looking into this and minimizing the test case. This isn't completely minimized, but it's a lot simpler than the full tuaw article. I probably won't have time to look at this for a little bit, so if someone else has time to look at it in the meantime, hopefully this will help.

[Simon Fraser (smfr)]

It looks like the render tree is OK, but the RenderLayer tree is missing some layers.

[Simon Fraser (smfr)]

Created attachment 241966 [details]
Standalone testcase

[Simon Fraser (smfr)]

Bem, did the testcase help?

[Bem Jones-Bey]

(In reply to comment #5)
> Bem, did the testcase help?

I was out all last week, and I haven't had a chance to look at it yet. It's on my list, though.

[Simon Fraser (smfr)]

Ping?

[Bem Jones-Bey]

(In reply to comment #7)
> Ping?

Unfortunately, there's been a sickness in my family, and I haven't gotten any work done in the past few days. I should be back at it as usual tomorrow.

One thing that would help: I seem to remember you mentioning that you had tracked this issue down to a particular commit. Can you remind me of which one that is? I had thought it was in the bug, but it's not.

[zalan]

(In reply to comment #8)
> (In reply to comment #7)
> > Ping?
> 
> Unfortunately, there's been a sickness in my family, and I haven't gotten
> any work done in the past few days. I should be back at it as usual tomorrow.
> 
> One thing that would help: I seem to remember you mentioning that you had
> tracked this issue down to a particular commit. Can you remind me of which
> one that is? I had thought it was in the bug, but it's not.
r155906. (it's in the title)

[Simon Fraser (smfr)]

It's in the title :)

[Bem Jones-Bey]

So, I have a fix, but I am having trouble creating a test for it. The render tree is always correct, and the test case renders fine both as a reftest and a pixel test. Anyone have any suggestions for how I might be able to write a test for this?

[Bem Jones-Bey]

Created attachment 242970 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 242970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242970&action=review

> Source/WebCore/ChangeLog:12
> +        it can change if the float's renderer has a self painting layer. So in

can change _whether_ the

[Bem Jones-Bey]

Created attachment 242974 [details]
Updated Patch

[WebKit Commit Bot]

Comment on attachment 242974 [details]
Updated Patch

Clearing flags on attachment: 242974

Committed r177049: <http://trac.webkit.org/changeset/177049>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.