Bug 12129 - repaint issue after setting viewBox attribute with ECMAScript
Summary: repaint issue after setting viewBox attribute with ECMAScript
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac (PowerPC) OS X 10.4
: P2 Normal
Assignee: Nobody
URL: http://www.carto.net/papers/svg/sampl...
Keywords:
Depends on:
Blocks: 12181
  Show dependency treegraph
 
Reported: 2007-01-05 12:15 PST by Andreas Neumann
Modified: 2007-01-09 07:29 PST (History)
0 users

See Also:


Attachments
First attempt (9.66 KB, patch)
2007-01-08 14:23 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Improved patch (9.08 KB, patch)
2007-01-09 03:12 PST, Rob Buis
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Neumann 2007-01-05 12:15:50 PST
In this example it seems like the viewBox is set correctly (after clicking on one of the green links right of the SVG (Vorarlberg, Salzburg, Austria)), but the SVG canvas does not update. If one scrolls the HTML down so that the SVG canvas isn't visible and then back to make the SVG canvas visible again, it seems to get updated.

Thanks for checking on this bug!
Comment 1 Rob Buis 2007-01-08 14:23:19 PST
Created attachment 12310 [details]
First attempt

This patch fixes the test svg given by Andreas.
Cheers,

Ron.
Comment 2 Rob Buis 2007-01-09 03:12:59 PST
Created attachment 12326 [details]
Improved patch

After talking things through with Eric, this may be a better approach.
Cheers,

Rob.
Comment 3 Eric Seidel (no email) 2007-01-09 03:19:35 PST
Comment on attachment 12326 [details]
Improved patch

We talked about some improvements to the test case over IRC.  The code looks good.  We'll need to fix dynamic updates of meet and slice as well (as those are equally broken).  Assuming you update the test case as we talked about, r=me.
Comment 4 Rob Buis 2007-01-09 07:29:29 PST
Landed in 18705.