Bug 121287 - ARM EABI hardfp buildfix after r155675
Summary: ARM EABI hardfp buildfix after r155675
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 108645 117281
  Show dependency tree / graph
 
Reported: 2013-09-13 03:31 PDT by Csaba Osztrogonác
Modified: 2013-09-13 08:54 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2013-09-13 03:56 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2013-09-13 03:31:40 PDT 
http://trac.webkit.org/changeset/155675 added a JSVALUE32_64 implementation of this function:
JITCompiler::Call callOperation(V_DFGOperation_EOZD operation, GPRReg arg1, GPRReg arg2, FPRReg arg3)
{
    m_jit.setupArgumentsWithExecState(arg1, arg2, EABI_32BIT_DUMMY_ARG arg3); ------> !!!
    return appendCallWithExceptionCheck(operation);
}

But unfortunately it added only softfp implementation of the following function:
ALWAYS_INLINE void setupArgumentsWithExecState(GPRReg arg1, GPRReg arg2, TrustedImm32 arg3, FPRReg arg4)

We need hardfp implementation too, which should be same as the GPRReg arg1, GPRReg arg2, FPRReg arg3
implementation, but it should simple ignore the dummy third argument. Fix is coming immediately.
Comment 1 Csaba Osztrogonác 2013-09-13 03:56:06 PDT 
Created attachment 211531 [details]
Patch

I got it. It was only a typo. The third argument is the dummy one, not the first one, similar to the call and the softfp implementation.
Comment 2 Geoffrey Garen 2013-09-13 08:27:03 PDT 
Comment on attachment 211531 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-09-13 08:54:53 PDT 
Comment on attachment 211531 [details]
Patch

Clearing flags on attachment: 211531

Committed r155705: <http://trac.webkit.org/changeset/155705>
Comment 4 WebKit Commit Bot 2013-09-13 08:54:55 PDT 
All reviewed patches have been landed.  Closing bug.