Bug 121216 - [mac] Public header WKBase.h imports a private header, WKBaseMac.h
Summary: [mac] Public header WKBase.h imports a private header, WKBaseMac.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords: InRadar
Depends on:
Blocks: 121215
  Show dependency tree / graph
 
Reported: 2013-09-11 23:55 PDT by mitz
Modified: 2013-09-14 10:06 PDT (History)
2 users (show)

See Also:

Attachments
Possible fix (69.51 KB, patch)
2013-09-13 01:24 PDT, mitz 		no flags Details | Formatted Diff | Diff
Move public parts of WKBase.h into new public headers, make WKBase.h private (72.73 KB, patch)
2013-09-14 00:58 PDT, mitz 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2013-09-11 23:55:22 PDT 
With a fix for bug 121215 in place, WebKit2 fails the include consistency check because WKBase.h is a public header, yet it include WKBaseMac.h, which is a private header.
Comment 1 mitz 2013-09-12 00:01:46 PDT 
<rdar://problem/14973091>
Comment 2 mitz 2013-09-13 01:24:04 PDT 
Created attachment 211519 [details]
Possible fix
Comment 3 Build Bot 2013-09-13 14:07:32 PDT 
Comment on attachment 211519 [details]
Possible fix

Attachment 211519 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1817149
Comment 4 mitz 2013-09-13 14:36:30 PDT 
(In reply to comment #3)
> (From update of attachment 211519 [details])
> Attachment 211519 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.appspot.com/results/1817149

This is just due to a stale WKBase.h in Headers in addition to the one newly installed in PrivateHeaders.
Comment 5 mitz 2013-09-14 00:58:05 PDT 
Created attachment 211632 [details]
Move public parts of WKBase.h into new public headers, make WKBase.h private
Comment 6 mitz 2013-09-14 10:06:43 PDT 
Fixed in <http://trac.webkit.org/r155770>. I had to add #includes in two or three more headers before landing so that WebKit2 clients will build.