Bug 121215 - [mac] Check For Framework Include Consistency build phase checks the wrong framework
Summary: [mac] Check For Framework Include Consistency build phase checks the wrong fr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 121216
Blocks:
  Show dependency tree / graph
 
Reported: 2013-09-11 23:52 PDT by mitz
Modified: 2013-09-14 14:35 PDT (History)
3 users (show)

See Also:

Attachments
Make check-for-webkit-framework-include-consistency check the framework being built, not WebKit.framework (2.44 KB, patch)
2013-09-12 00:00 PDT, mitz 		mrowe: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2013-09-11 23:52:55 PDT 
The Check For Framework Include Consistency build phase invokes check-for-webkit-framework-include-consistency, which is hard-coded to check WebKit.framework rather than the target’s build product.
Comment 1 mitz 2013-09-12 00:00:13 PDT 
Created attachment 211405 [details]
Make check-for-webkit-framework-include-consistency check the framework being built, not WebKit.framework
Comment 2 mitz 2013-09-12 00:01:19 PDT 
Note: this can’t be landed as-is until bug 121216 is fixed.
Comment 3 Build Bot 2013-09-12 00:21:53 PDT 
Comment on attachment 211405 [details]
Make check-for-webkit-framework-include-consistency check the framework being built, not WebKit.framework

Attachment 211405 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1856048
Comment 4 Build Bot 2013-09-12 00:40:41 PDT 
Comment on attachment 211405 [details]
Make check-for-webkit-framework-include-consistency check the framework being built, not WebKit.framework

Attachment 211405 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1843048
Comment 5 mitz 2013-09-14 14:35:12 PDT 
Fixed in <http://trac.webkit.org/r155788>.