RESOLVED FIXED 121102
MediaStream API: Update RTCDataChannel 
https://bugs.webkit.org/show_bug.cgi?id=121102
Summary MediaStream API: Update RTCDataChannel
Attachments
Proposed patch (16.60 KB, patch)
2013-09-13 23:39 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 2 2013-09-13 23:39:08 PDT
Created attachment 211627 [details] Proposed patch
Eric Carlson
Comment 3 2013-09-14 16:11:30 PDT
I will need to update this patch once bug 120889 lands.
Sam Weinig
Comment 4 2013-09-14 16:59:59 PDT
Comment on attachment 211627 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=211627&action=review > Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:68 > + if (options.get("id", value)) > + initData.id = value; > + if (options.get("maxRetransmits", value)) > + initData.maxRetransmits = value; > + if (options.get("maxRetransmitTime", value)) > + initData.maxRetransmitTime = value; Can these be written without the if? Just options.get("id", initData.id)), etc? > Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:72 > + String protocolString; > + options.get("protocol", protocolString); > + initData.protocol = protocolString; Can this be written as options.get("protocol", initData.protocol); ? > Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:143 > + DEFINE_STATIC_LOCAL(String, connectingState, ("connecting", AtomicString::ConstructFromLiteral)); > + DEFINE_STATIC_LOCAL(String, openState, ("open", AtomicString::ConstructFromLiteral)); > + DEFINE_STATIC_LOCAL(String, closingState, ("closing", AtomicString::ConstructFromLiteral)); > + DEFINE_STATIC_LOCAL(String, closedState, ("closed", AtomicString::ConstructFromLiteral)); Can we use NeverDestroyed<> instead?
Eric Carlson
Comment 5 2013-09-14 19:32:17 PDT
Committed r155794: https://trac.webkit.org/r155794
Note You need to log in before you can comment on or make changes to this bug.