Bug 120889 - MediaStream API: Update RTCDataChannel to match the specification
Summary: MediaStream API: Update RTCDataChannel to match the specification
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks: 121101
  Show dependency treegraph
 
Reported: 2013-09-06 13:08 PDT by Eric Carlson
Modified: 2013-09-14 17:52 PDT (History)
9 users (show)

See Also:


Attachments
Patch (5.05 KB, patch)
2013-09-14 15:50 PDT, Thiago de Barros Lacerda
no flags Details | Formatted Diff | Diff
Patch (5.05 KB, patch)
2013-09-14 15:52 PDT, Thiago de Barros Lacerda
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-09-06 13:08:08 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/c3862b0a83e20fc8b1f770c7e4a886a7cceb80d2 

Just adding a bunch of attributes and deprecating one.
Comment 1 Thiago de Barros Lacerda 2013-09-14 15:50:17 PDT
Created attachment 211670 [details]
Patch
Comment 2 Thiago de Barros Lacerda 2013-09-14 15:52:03 PDT
Created attachment 211671 [details]
Patch
Comment 3 Eric Carlson 2013-09-14 16:13:49 PDT
Comment on attachment 211671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211671&action=review

> Source/WebCore/ChangeLog:19
> +        According to WebRTC specification, RTCDataChannel must have the following new attributes:
> +        boolean ordered
> +        unsigned short maxRetransmitTime
> +        unsigned short maxRetransmits
> +        DOMString protocol
> +        boolean negotiated
> +        unsigned short id
> +
> +        and the following one was deprecated:
> +        boolean reliable
> +
> +        No new tests needed.

Please not the blink revision this was merged from.
Comment 4 Eric Carlson 2013-09-14 16:14:13 PDT
(In reply to comment #3)
> (From update of attachment 211671 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211671&action=review
> 
> > Source/WebCore/ChangeLog:19
> > +        According to WebRTC specification, RTCDataChannel must have the following new attributes:
> > +        boolean ordered
> > +        unsigned short maxRetransmitTime
> > +        unsigned short maxRetransmits
> > +        DOMString protocol
> > +        boolean negotiated
> > +        unsigned short id
> > +
> > +        and the following one was deprecated:
> > +        boolean reliable
> > +
> > +        No new tests needed.
> 
> Please not the blink revision this was merged from.

Please *note* the revision.
Comment 5 Eric Carlson 2013-09-14 16:31:20 PDT
Comment on attachment 211671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211671&action=review

>>> Source/WebCore/ChangeLog:19
>>> +        No new tests needed.
>> 
>> Please not the blink revision this was merged from.
> 
> Please *note* the revision.

I will update RTCPeerConnection-datachannel.html with bug 121102.
Comment 6 Eric Carlson 2013-09-14 17:16:09 PDT
I will land this.
Comment 7 Eric Carlson 2013-09-14 17:52:06 PDT
Committed in r155792: : https://trac.webkit.org/r155792