Bug 121087 – toFooElement() should use static_cast, not reinterpret_cast.

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Andreas Kling]

Have patch.

[Andreas Kling]

Created attachment 211184 [details]
Patch

Didn't actually try to build this yet. Let's see how it goes..

[Antti Koivisto]

Comment on attachment 211184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211184&action=review

> Source/WebCore/ChangeLog:19
> +            - void toFooElement(constNode*)

missing space

> Source/WebCore/dom/Node.h:786
> +void to##NodeSubclassName(const NodeSubclassName*); \
> +void to##NodeSubclassName(const NodeSubclassName&);
> +

Anders suggested to use WTF_DELETE_FUNCTION. Does that not work?

[Early Warning System Bot]

Comment on attachment 211184 [details]
Patch

Attachment 211184 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1764025

[Early Warning System Bot]

Comment on attachment 211184 [details]
Patch

Attachment 211184 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1764027

[Andreas Kling]

Created attachment 211186 [details]
Patch

[Antti Koivisto]

Comment on attachment 211184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211184&action=review

> Source/WebCore/html/HTMLAnchorElement.h:158
> +NODE_TYPE_CASTS(HTMLAnchorElement)

Since this only applies to Elements ELEMENT_TYPE_CASTS might be a better name.

[Andreas Kling]

(In reply to comment #2)
> (From update of attachment 211184 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211184&action=review
> > Source/WebCore/dom/Node.h:786
> > +void to##NodeSubclassName(const NodeSubclassName*); \
> > +void to##NodeSubclassName(const NodeSubclassName&);
> > +
> 
> Anders suggested to use WTF_DELETE_FUNCTION. Does that not work?

Apparently not. It just says "no previous definition for toHurrElement()"

[Build Bot]

Comment on attachment 211184 [details]
Patch

Attachment 211184 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1734563

[WebKit Commit Bot]

Comment on attachment 211186 [details]
Patch

Clearing flags on attachment: 211186

Committed r155429: <http://trac.webkit.org/changeset/155429>

[Build Bot]

Comment on attachment 211184 [details]
Patch

Attachment 211184 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1735493

[EFL EWS Bot]

Comment on attachment 211184 [details]
Patch

Attachment 211184 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1763048

[Lucas Forschler]

Mass moving XML DOM bugs to the "DOM" Component.