Bug 121080 - Generate more HTML type checks and casting
Summary: Generate more HTML type checks and casting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on: 121087
Blocks:
  Show dependency tree / graph
 
Reported: 2013-09-09 23:40 PDT by Gyuyoung Kim
Modified: 2013-09-11 01:02 PDT (History)
7 users (show)

See Also:

Attachments
Patch (40.43 KB, patch)
2013-09-09 23:48 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (40.43 KB, patch)
2013-09-09 23:53 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (40.43 KB, patch)
2013-09-10 00:30 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (40.83 KB, patch)
2013-09-10 18:24 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-09-09 23:40:56 PDT 
Clean-up remained functions of HTML elements to auto-generated isFooElement() and toFooElement() helpers. Besides this patch clean-up unnecessary checks which are being supported by auto-generated isFooElement().
Comment 1 Gyuyoung Kim 2013-09-09 23:48:22 PDT 
Created attachment 211174 [details]
Patch
Comment 2 Gyuyoung Kim 2013-09-09 23:53:13 PDT 
Created attachment 211175 [details]
Patch
Comment 3 Gyuyoung Kim 2013-09-09 23:54:56 PDT 
CC'ing Kling.
Comment 4 Early Warning System Bot 2013-09-10 00:05:02 PDT 
Comment on attachment 211175 [details]
Patch

Attachment 211175 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1752009
Comment 5 Early Warning System Bot 2013-09-10 00:08:04 PDT 
Comment on attachment 211175 [details]
Patch

Attachment 211175 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1743138
Comment 6 Build Bot 2013-09-10 00:17:44 PDT 
Comment on attachment 211175 [details]
Patch

Attachment 211175 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1761010
Comment 7 Gyuyoung Kim 2013-09-10 00:30:09 PDT 
Created attachment 211180 [details]
Patch
Comment 8 Andreas Kling 2013-09-10 00:31:32 PDT 
Unfortunately we need to make toFooElement() use static_cast instead of reinterpret_cast as mentioned here:
https://bugs.webkit.org/show_bug.cgi?id=120676#c8
Comment 9 Gyuyoung Kim 2013-09-10 00:39:25 PDT 
(In reply to comment #8)
> Unfortunately we need to make toFooElement() use static_cast instead of reinterpret_cast as mentioned here:
> https://bugs.webkit.org/show_bug.cgi?id=120676#c8

Kling, yes, I talked it with kent on blink. But, it looks it is not easy. I need to have time to change it. *ElementTypeHelper.h may need to include all *Element.h.
Comment 10 Gyuyoung Kim 2013-09-10 00:44:55 PDT 
Comment on attachment 211180 [details]
Patch

No request until solving reinterpret_cast<> problem.
Comment 11 Andreas Kling 2013-09-10 01:46:10 PDT 
Sure, I opened bug 121087 with a patch so we can at least have correct C++ until a better solution is found :)
Comment 12 kov's GTK+ EWS bot 2013-09-10 06:13:19 PDT 
Comment on attachment 211180 [details]
Patch

Attachment 211180 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1735497
Comment 13 Gyuyoung Kim 2013-09-10 18:24:27 PDT 
Created attachment 211272 [details]
Patch
Comment 14 WebKit Commit Bot 2013-09-11 01:02:00 PDT 
Comment on attachment 211272 [details]
Patch

Clearing flags on attachment: 211272

Committed r155507: <http://trac.webkit.org/changeset/155507>
Comment 15 WebKit Commit Bot 2013-09-11 01:02:06 PDT 
All reviewed patches have been landed.  Closing bug.