Bug 121058 - Remove HTMLTextFormControl::fixPlaceholderRenderer
Summary: Remove HTMLTextFormControl::fixPlaceholderRenderer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 87155
Blocks: 120685 121073
  Show dependency tree / graph
 
Reported: 2013-09-09 16:31 PDT by Ryosuke Niwa
Modified: 2013-09-09 21:08 PDT (History)
4 users (show)

See Also:

Attachments
Cleanup (17.33 KB, patch)
2013-09-09 17:04 PDT, Ryosuke Niwa 		tkent: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-09-09 16:31:15 PDT 
Observe:

-void HTMLTextFormControlElement::fixPlaceholderRenderer(HTMLElement* placeholder, HTMLElement* siblingElement)
-{
-    // FIXME: We should change the order of DOM nodes. But it makes an assertion
-    // failure in editing code.

That's because the assertion is bogus.
Comment 1 Ryosuke Niwa 2013-09-09 17:04:27 PDT 
Created attachment 211121 [details]
Cleanup
Comment 2 Ryosuke Niwa 2013-09-09 17:08:49 PDT 
I guess I should mention that this was inspired by https://chromium.googlesource.com/chromium/blink/+/2abaaaad08b1b5802da65a8797f4bec721eec952 but my patch is nothing like Blink's.
Comment 3 Kent Tamura 2013-09-09 17:22:21 PDT 
(In reply to comment #2)
> I guess I should mention that this was inspired by https://chromium.googlesource.com/chromium/blink/+/2abaaaad08b1b5802da65a8797f4bec721eec952 but my patch is nothing like Blink's.

Your patch is the right fix, and it is different from the Blink change.
Comment 4 Kent Tamura 2013-09-09 17:23:24 PDT 
Comment on attachment 211121 [details]
Cleanup

ok
Comment 5 Ryosuke Niwa 2013-09-09 18:07:42 PDT 
Committed r155408: <http://trac.webkit.org/changeset/155408>