WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
121036
Move the layoutBlock method into RenderBlockFlow.
https://bugs.webkit.org/show_bug.cgi?id=121036
Summary
Move the layoutBlock method into RenderBlockFlow.
Dave Hyatt
Reported
2013-09-09 11:58:11 PDT
Begin the process of moving layout into RenderBlockFlow.
Attachments
Patch
(43.83 KB, patch)
2013-09-09 12:09 PDT
,
Dave Hyatt
dino
: review+
Details
Formatted Diff
Diff
Patch to pass the style queue
(43.62 KB, patch)
2013-09-09 12:22 PDT
,
Dave Hyatt
hyatt
: review-
Details
Formatted Diff
Diff
Patch
(43.62 KB, patch)
2013-09-09 12:50 PDT
,
Dave Hyatt
hyatt
: review-
Details
Formatted Diff
Diff
Patch
(52.52 KB, patch)
2013-09-09 12:51 PDT
,
Dave Hyatt
dino
: review+
webkit-ews
: commit-queue-
Details
Formatted Diff
Diff
Patch to account for Antti's patch landing. :)
(52.55 KB, patch)
2013-09-09 12:58 PDT
,
Dave Hyatt
dino
: review+
Details
Formatted Diff
Diff
Make release builds work by removing some inlining for now.
(53.01 KB, patch)
2013-09-09 13:04 PDT
,
Dave Hyatt
dino
: review+
Details
Formatted Diff
Diff
Show Obsolete
(5)
View All
Add attachment
proposed patch, testcase, etc.
Dave Hyatt
Comment 1
2013-09-09 12:09:32 PDT
Created
attachment 211061
[details]
Patch
WebKit Commit Bot
Comment 2
2013-09-09 12:12:23 PDT
Attachment 211061
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/svg/RenderSVGText.cpp']" exit_code: 1 Source/WebCore/rendering/RenderBlockFlow.cpp:94: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/rendering/RenderBlockFlow.cpp:197: One space before end of line comments [whitespace/comments] [5] Source/WebCore/rendering/RenderBlockFlow.cpp:197: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/rendering/RenderBlockFlow.cpp:229: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/rendering/RenderBlockFlow.cpp:233: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/rendering/RenderBlockFlow.cpp:236: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/rendering/RenderBlockFlow.cpp:320: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/rendering/RenderBlockFlow.cpp:325: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/rendering/RenderBlockFlow.cpp:374: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/rendering/RenderBlockFlow.cpp:378: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 10 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3
2013-09-09 12:22:11 PDT
Created
attachment 211065
[details]
Patch to pass the style queue
WebKit Commit Bot
Comment 4
2013-09-09 12:23:29 PDT
Attachment 211065
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/svg/RenderSVGText.cpp']" exit_code: 1 Source/WebCore/rendering/RenderBlockFlow.cpp:371: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 5
2013-09-09 12:50:50 PDT
Created
attachment 211067
[details]
Patch
Dave Hyatt
Comment 6
2013-09-09 12:51:36 PDT
Created
attachment 211068
[details]
Patch
Early Warning System Bot
Comment 7
2013-09-09 12:58:12 PDT
Comment on
attachment 211068
[details]
Patch
Attachment 211068
[details]
did not pass qt-ews (qt): Output:
http://webkit-queues.appspot.com/results/1719954
Dave Hyatt
Comment 8
2013-09-09 12:58:54 PDT
Created
attachment 211069
[details]
Patch to account for Antti's patch landing. :)
Dean Jackson
Comment 9
2013-09-09 13:00:23 PDT
Comment on
attachment 211069
[details]
Patch to account for Antti's patch landing. :) Needs more <ruby>!
Dave Hyatt
Comment 10
2013-09-09 13:04:02 PDT
Created
attachment 211072
[details]
Make release builds work by removing some inlining for now.
Dave Hyatt
Comment 11
2013-09-09 13:22:24 PDT
Fix landed in
r155377
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug