WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
120972
FTL should support typed array PutByVal
https://bugs.webkit.org/show_bug.cgi?id=120972
Summary
FTL should support typed array PutByVal
Filip Pizlo
Reported
2013-09-07 15:32:43 PDT
Patch forthcoming.
Attachments
the patch
(19.14 KB, patch)
2013-09-07 15:33 PDT
,
Filip Pizlo
oliver
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2013-09-07 15:33:24 PDT
Created
attachment 210928
[details]
the patch
WebKit Commit Bot
Comment 2
2013-09-07 15:35:25 PDT
Attachment 210928
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/ftl/FTLAbbreviations.h', u'Source/JavaScriptCore/ftl/FTLCapabilities.cpp', u'Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp', u'Source/JavaScriptCore/ftl/FTLOutput.h']" exit_code: 1 Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:2219: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3
2013-09-07 15:43:31 PDT
(In reply to
comment #2
)
>
Attachment 210928
[details]
did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/ftl/FTLAbbreviations.h', u'Source/JavaScriptCore/ftl/FTLCapabilities.cpp', u'Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp', u'Source/JavaScriptCore/ftl/FTLOutput.h']" exit_code: 1 > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:2219: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Fixed.
> Total errors found: 1 in 6 files > > > If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 4
2013-09-07 19:48:25 PDT
Comment on
attachment 210928
[details]
the patch View in context:
https://bugs.webkit.org/attachment.cgi?id=210928&action=review
>> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:2219 >> + > > Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Random spaces by the looks
Filip Pizlo
Comment 5
2013-09-07 21:07:31 PDT
Landed in
http://trac.webkit.org/changeset/155281
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug