Bug 120911 – Add a new smart pointer type for fastMalloc'ed memory

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Add a new smart pointer type for fastMalloc'ed memory

[Anders Carlsson]

Created attachment 210820 [details]
Patch

[WebKit Commit Bot]

Attachment 210820 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.pro', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.vcxproj/WTF.vcxproj.filters', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/CMakeLists.txt', u'Source/WTF/wtf/MallocPtr.h', u'Source/WTF/wtf/Vector.h', u'Source/WTF/wtf/text/StringBuffer.h', u'Source/WTF/wtf/text/StringImpl.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp']" exit_code: 1
Source/WTF/wtf/MallocPtr.h:63:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 210820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210820&action=review

> Source/WTF/ChangeLog:11
> +        Fix this by introducing a new MllocPtr smart pointer class and change Vector::releaseBuffer() to return it instead.

Due to an oversight on your part, it says MllocPtr here.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 210820 [details]:

http/tests/inspector/inspect-element.html bug 78869 (author: [e-mail])
fast/regions/autoheight-singleregion-breakbeforealways.html bug 120924 (authors: [e-mail] and [e-mail])
fast/regions/autoheight-secondregion-breakoutside.html bug 120925 (author: [e-mail])
fast/regions/autoheight-singleregion-breakafteralways-maxheight.html bug 120926 (authors: [e-mail] and [e-mail])
fast/regions/autoheight-lastregion-overflowauto-breaksignored.html bug 120927 (author: [e-mail])
fast/regions/autowidth-normalflow-minmaxwidth.html bug 120928 (author: [e-mail])
fast/regions/autoheight-singleregion-overflowauto.html bug 120929 (author: [e-mail])
fast/regions/autoheight-allregions.html bug 120930 (author: [e-mail])
fast/regions/autoheight-definedheight-changenotdetected.html bug 120931 (author: [e-mail])
fast/regions/autoheight-vertical-rl.html bug 120932 (author: [e-mail])
fast/regions/autowidth-normalflow-minwidth.html bug 120933 (author: [e-mail])
fast/regions/autoheight-singleregion-breakafteralways.html bug 120934 (authors: [e-mail] and [e-mail])
fast/regions/autoheight-secondregion.html bug 120935 (author: [e-mail])
fast/regions/autoheight-singleregion-breakaftermargin.html bug 120936 (authors: [e-mail] and [e-mail])
fast/regions/autoheight-horizontal-bt.html bug 120937 (author: [e-mail])
fast/regions/autoheight-middleregion.html bug 120938 (author: [e-mail])
fast/regions/autoheight-singleregion-multiplebreaks.html bug 120939 (authors: [e-mail] and [e-mail])
fast/regions/autowidth-normalflow-vertrl.html bug 120951 (author: [e-mail])
fast/regions/autoheight-singleregion-overflowauto-breaksignored.html bug 120940 (author: [e-mail])
fast/regions/autoheight-breakbeforealways.html bug 120941 (authors: [e-mail] and [e-mail])
fast/regions/autoheight-firstregion-breakalways.html bug 120942 (author: [e-mail])
fast/regions/autoheight-allregions-nobreaks.html bug 120943 (author: [e-mail])
fast/regions/autoheight-dynamic-update.html bug 120944 (author: [e-mail])
fast/regions/autoheight-breakafteralways-maxheight.html bug 120945 (authors: [e-mail] and [e-mail])
fast/regions/autoheight-lastregion-overflowauto.html bug 120946 (author: [e-mail])
fast/regions/autoheight-maxheight-region.html bug 120947 (author: [e-mail])
fast/regions/autoheight-vertical-lr.html bug 120948 (author: [e-mail])
fast/shapes/shape-outside-floats/shape-outside-floats-image-002.html bug 120755 (author: [e-mail])
fast/shapes/shape-outside-floats/shape-outside-floats-image-001.html bug 120755 (author: [e-mail])
animations/cross-fade-background-image.html bug 120950 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 210820 [details]
Patch

Clearing flags on attachment: 210820

Committed r155242: <http://trac.webkit.org/changeset/155242>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.