WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
120911
Add a new smart pointer type for fastMalloc'ed memory
https://bugs.webkit.org/show_bug.cgi?id=120911
Summary
Add a new smart pointer type for fastMalloc'ed memory
Anders Carlsson
Reported
2013-09-06 16:58:18 PDT
Add a new smart pointer type for fastMalloc'ed memory
Attachments
Patch
(16.32 KB, patch)
2013-09-06 17:27 PDT
,
Anders Carlsson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2013-09-06 17:27:59 PDT
Created
attachment 210820
[details]
Patch
WebKit Commit Bot
Comment 2
2013-09-06 17:30:53 PDT
Attachment 210820
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.pro', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.vcxproj/WTF.vcxproj.filters', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/CMakeLists.txt', u'Source/WTF/wtf/MallocPtr.h', u'Source/WTF/wtf/Vector.h', u'Source/WTF/wtf/text/StringBuffer.h', u'Source/WTF/wtf/text/StringImpl.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp']" exit_code: 1 Source/WTF/wtf/MallocPtr.h:63: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3
2013-09-06 17:31:46 PDT
Comment on
attachment 210820
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=210820&action=review
> Source/WTF/ChangeLog:11 > + Fix this by introducing a new MllocPtr smart pointer class and change Vector::releaseBuffer() to return it instead.
Due to an oversight on your part, it says MllocPtr here.
WebKit Commit Bot
Comment 4
2013-09-06 22:34:45 PDT
The commit-queue encountered the following flaky tests while processing
attachment 210820
[details]
: http/tests/inspector/inspect-element.html
bug 78869
(author:
pfeldman@chromium.org
) fast/regions/autoheight-singleregion-breakbeforealways.html
bug 120924
(authors:
mihnea@adobe.com
and
stavila@adobe.com
) fast/regions/autoheight-secondregion-breakoutside.html
bug 120925
(author:
mihnea@adobe.com
) fast/regions/autoheight-singleregion-breakafteralways-maxheight.html
bug 120926
(authors:
mihnea@adobe.com
and
stavila@adobe.com
) fast/regions/autoheight-lastregion-overflowauto-breaksignored.html
bug 120927
(author:
mihnea@adobe.com
) fast/regions/autowidth-normalflow-minmaxwidth.html
bug 120928
(author:
mihnea@adobe.com
) fast/regions/autoheight-singleregion-overflowauto.html
bug 120929
(author:
mihnea@adobe.com
) fast/regions/autoheight-allregions.html
bug 120930
(author:
mihnea@adobe.com
) fast/regions/autoheight-definedheight-changenotdetected.html
bug 120931
(author:
mihnea@adobe.com
) fast/regions/autoheight-vertical-rl.html
bug 120932
(author:
mihnea@adobe.com
) fast/regions/autowidth-normalflow-minwidth.html
bug 120933
(author:
mihnea@adobe.com
) fast/regions/autoheight-singleregion-breakafteralways.html
bug 120934
(authors:
mihnea@adobe.com
and
stavila@adobe.com
) fast/regions/autoheight-secondregion.html
bug 120935
(author:
mihnea@adobe.com
) fast/regions/autoheight-singleregion-breakaftermargin.html
bug 120936
(authors:
mihnea@adobe.com
and
stavila@adobe.com
) fast/regions/autoheight-horizontal-bt.html
bug 120937
(author:
mihnea@adobe.com
) fast/regions/autoheight-middleregion.html
bug 120938
(author:
mihnea@adobe.com
) fast/regions/autoheight-singleregion-multiplebreaks.html
bug 120939
(authors:
mihnea@adobe.com
and
stavila@adobe.com
) fast/regions/autowidth-normalflow-vertrl.html
bug 120951
(author:
mihnea@adobe.com
) fast/regions/autoheight-singleregion-overflowauto-breaksignored.html
bug 120940
(author:
mihnea@adobe.com
) fast/regions/autoheight-breakbeforealways.html
bug 120941
(authors:
mihnea@adobe.com
and
stavila@adobe.com
) fast/regions/autoheight-firstregion-breakalways.html
bug 120942
(author:
mihnea@adobe.com
) fast/regions/autoheight-allregions-nobreaks.html
bug 120943
(author:
mihnea@adobe.com
) fast/regions/autoheight-dynamic-update.html
bug 120944
(author:
achicu@adobe.com
) fast/regions/autoheight-breakafteralways-maxheight.html
bug 120945
(authors:
mihnea@adobe.com
and
stavila@adobe.com
) fast/regions/autoheight-lastregion-overflowauto.html
bug 120946
(author:
mihnea@adobe.com
) fast/regions/autoheight-maxheight-region.html
bug 120947
(author:
mihnea@adobe.com
) fast/regions/autoheight-vertical-lr.html
bug 120948
(author:
mihnea@adobe.com
) fast/shapes/shape-outside-floats/shape-outside-floats-image-002.html
bug 120755
(author:
giles_joplin@yahoo.com
) fast/shapes/shape-outside-floats/shape-outside-floats-image-001.html
bug 120755
(author:
giles_joplin@yahoo.com
) animations/cross-fade-background-image.html
bug 120950
(authors:
krit@webkit.org
and
thorton@apple.com
) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5
2013-09-06 22:35:43 PDT
Comment on
attachment 210820
[details]
Patch Clearing flags on attachment: 210820 Committed
r155242
: <
http://trac.webkit.org/changeset/155242
>
WebKit Commit Bot
Comment 6
2013-09-06 22:35:46 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug