Bug 120890 - Concurrent FTL causes !hasOptimizedReplacement() asserts in cti_optimize
Summary: Concurrent FTL causes !hasOptimizedReplacement() asserts in cti_optimize
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Blocks: 112840
  Show dependency treegraph
Reported: 2013-09-06 13:12 PDT by Filip Pizlo
Modified: 2013-09-06 13:19 PDT (History)
7 users (show)

See Also:

the patch (1.62 KB, patch)
2013-09-06 13:13 PDT, Filip Pizlo
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-09-06 13:12:56 PDT
This is because the FTL may install an optimized replacement while the DFG has already been jettisoned - so then the baseline JIT's cti_optimize sees an on-going DFG compile to reoptimize the code while also seeing an FTL optimized replacement.
Comment 1 Filip Pizlo 2013-09-06 13:13:51 PDT
Created attachment 210786 [details]
the patch
Comment 2 Filip Pizlo 2013-09-06 13:17:16 PDT
Comment on attachment 210786 [details]
the patch

Comment 3 Filip Pizlo 2013-09-06 13:19:32 PDT
Landed in http://trac.webkit.org/changeset/155209