Bug 120884 - Web Inspector: Lint JavaScript and CSS for minor issues
Summary: Web Inspector: Lint JavaScript and CSS for minor issues
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-09-06 12:45 PDT by Joseph Pecoraro
Modified: 2013-09-06 22:33 PDT (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (33.24 KB, patch)
2013-09-06 12:46 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-09-06 12:45:19 PDT
I ran JSHint / CSSLint and caught some minor issues.
Comment 1 Radar WebKit Bug Importer 2013-09-06 12:45:51 PDT
<rdar://problem/14931854>
Comment 2 Joseph Pecoraro 2013-09-06 12:46:24 PDT
Created attachment 210780 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2013-09-06 22:32:56 PDT
The commit-queue encountered the following flaky tests while processing attachment 210780 [details]:

http/tests/inspector/inspect-element.html bug 78869 (author: pfeldman@chromium.org)
fast/regions/autoheight-singleregion-breakbeforealways.html bug 120924 (authors: mihnea@adobe.com and stavila@adobe.com)
fast/regions/autoheight-secondregion-breakoutside.html bug 120925 (author: mihnea@adobe.com)
fast/regions/autoheight-singleregion-breakafteralways-maxheight.html bug 120926 (authors: mihnea@adobe.com and stavila@adobe.com)
fast/regions/autoheight-lastregion-overflowauto-breaksignored.html bug 120927 (author: mihnea@adobe.com)
fast/regions/autowidth-normalflow-minmaxwidth.html bug 120928 (author: mihnea@adobe.com)
fast/regions/autoheight-singleregion-overflowauto.html bug 120929 (author: mihnea@adobe.com)
fast/regions/autoheight-allregions.html bug 120930 (author: mihnea@adobe.com)
fast/regions/autoheight-definedheight-changenotdetected.html bug 120931 (author: mihnea@adobe.com)
fast/regions/autoheight-vertical-rl.html bug 120932 (author: mihnea@adobe.com)
fast/regions/autowidth-normalflow-minwidth.html bug 120933 (author: mihnea@adobe.com)
fast/regions/autoheight-singleregion-breakafteralways.html bug 120934 (authors: mihnea@adobe.com and stavila@adobe.com)
fast/regions/autoheight-secondregion.html bug 120935 (author: mihnea@adobe.com)
fast/regions/autoheight-singleregion-breakaftermargin.html bug 120936 (authors: mihnea@adobe.com and stavila@adobe.com)
fast/regions/autoheight-horizontal-bt.html bug 120937 (author: mihnea@adobe.com)
fast/regions/autoheight-middleregion.html bug 120938 (author: mihnea@adobe.com)
fast/regions/autoheight-singleregion-multiplebreaks.html bug 120939 (authors: mihnea@adobe.com and stavila@adobe.com)
fast/regions/autoheight-singleregion-overflowauto-breaksignored.html bug 120940 (author: mihnea@adobe.com)
fast/regions/autoheight-breakbeforealways.html bug 120941 (authors: mihnea@adobe.com and stavila@adobe.com)
fast/regions/autoheight-firstregion-breakalways.html bug 120942 (author: mihnea@adobe.com)
fast/regions/autoheight-allregions-nobreaks.html bug 120943 (author: mihnea@adobe.com)
fast/regions/autoheight-dynamic-update.html bug 120944 (author: achicu@adobe.com)
fast/regions/autoheight-breakafteralways-maxheight.html bug 120945 (authors: mihnea@adobe.com and stavila@adobe.com)
fast/regions/autoheight-lastregion-overflowauto.html bug 120946 (author: mihnea@adobe.com)
fast/regions/autoheight-maxheight-region.html bug 120947 (author: mihnea@adobe.com)
fast/regions/autoheight-vertical-lr.html bug 120948 (author: mihnea@adobe.com)
fast/inline/layout-after-inserting-nested-br.html bug 120755 (author: robert@webkit.org)
fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html bug 120755 (author: betravis@adobe.com)
fast/shapes/shape-inside/shape-inside-overflow.html bug 120949 (authors: betravis@adobe.com and zoltan@webkit.org)
animations/cross-fade-background-image.html bug 120950 (authors: krit@webkit.org and thorton@apple.com)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2013-09-06 22:33:52 PDT
Comment on attachment 210780 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 210780

Committed r155241: <http://trac.webkit.org/changeset/155241>
Comment 5 WebKit Commit Bot 2013-09-06 22:33:54 PDT
All reviewed patches have been landed.  Closing bug.