Bug 120861 - Adding username to RTCIceServer
Summary: Adding username to RTCIceServer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 120877 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-09-06 06:59 PDT by Thiago de Barros Lacerda
Modified: 2013-09-09 06:46 PDT (History)
12 users (show)

See Also:


Attachments
Patch (3.35 KB, patch)
2013-09-06 07:18 PDT, Thiago de Barros Lacerda
no flags Details | Formatted Diff | Diff
Patch (3.40 KB, patch)
2013-09-06 13:19 PDT, Thiago de Barros Lacerda
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago de Barros Lacerda 2013-09-06 06:59:31 PDT
According to the specification (http://dev.w3.org/2011/webrtc/editor/webrtc.html#idl-def-RTCIceServer) RTCIceServer has a username field.
Comment 1 Thiago de Barros Lacerda 2013-09-06 07:18:12 PDT
Created attachment 210756 [details]
Patch
Comment 2 Noam Rosenthal 2013-09-06 07:33:17 PDT
Comment on attachment 210756 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210756&action=review

Overall comments

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Don't leave this OOPS in. Are there current tests for RTC?
Comment 3 Thiago de Barros Lacerda 2013-09-06 13:19:45 PDT
Created attachment 210788 [details]
Patch
Comment 4 Eric Carlson 2013-09-06 13:34:25 PDT
This looks like it was merged from https://chromium.googlesource.com/chromium/blink/+/415abb016c34a595d8c2d3b0d62d8b804d734ee2%5E%21. Please mention this if this is so.
Comment 5 Eric Carlson 2013-09-06 13:35:01 PDT
*** Bug 120877 has been marked as a duplicate of this bug. ***
Comment 6 Thiago de Barros Lacerda 2013-09-06 16:07:47 PDT
(In reply to comment #4)
> This looks like it was merged from https://chromium.googlesource.com/chromium/blink/+/415abb016c34a595d8c2d3b0d62d8b804d734ee2%5E%21. Please mention this if this is so.

Hi Eric. I haven't seen this patch from blink, but, indeed, it does the same thing
Comment 7 Thiago de Barros Lacerda 2013-09-08 14:23:09 PDT
(In reply to comment #6)
> (In reply to comment #4)
> > This looks like it was merged from https://chromium.googlesource.com/chromium/blink/+/415abb016c34a595d8c2d3b0d62d8b804d734ee2%5E%21. Please mention this if this is so.
> 
> Hi Eric. I haven't seen this patch from blink, but, indeed, it does the same thing

(In reply to comment #6)
> (In reply to comment #4)
> > This looks like it was merged from https://chromium.googlesource.com/chromium/blink/+/415abb016c34a595d8c2d3b0d62d8b804d734ee2%5E%21. Please mention this if this is so.
> 
> Hi Eric. I haven't seen this patch from blink, but, indeed, it does the same thing

Also I haven't looked the blink's source code when doing this patch. Should I mention it anyway?
Comment 8 Eric Carlson 2013-09-08 16:36:53 PDT
(In reply to comment #7)
> 
> Also I haven't looked the blink's source code when doing this patch. Should I mention it anyway?

No, there is no need.
Comment 9 WebKit Commit Bot 2013-09-09 06:46:22 PDT
Comment on attachment 210788 [details]
Patch

Clearing flags on attachment: 210788

Committed r155346: <http://trac.webkit.org/changeset/155346>
Comment 10 WebKit Commit Bot 2013-09-09 06:46:26 PDT
All reviewed patches have been landed.  Closing bug.