Bug 120547 - Animations should use double for key values, not floats
Summary: Animations should use double for key values, not floats
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: BlinkMergeCandidate
Depends on: 120600
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-30 13:36 PDT by Dean Jackson
Modified: 2013-09-02 06:56 PDT (History)
10 users (show)

See Also:

Attachments
Patch (10.55 KB, patch)
2013-08-30 13:39 PDT, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Dean Jackson 2013-08-30 13:39:33 PDT 
Created attachment 210157 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-08-30 14:15:32 PDT 
Comment on attachment 210157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210157&action=review

> Source/WebCore/css/WebKitCSSKeyframeRule.cpp:69
> +            double k = cur.substring(0, cur.length() - 1).toFloat();

Is there a toDouble()?
Comment 3 Dean Jackson 2013-08-30 14:47:27 PDT 
Committed r154909: <http://trac.webkit.org/changeset/154909>
Comment 4 Csaba Osztrogonác 2013-09-02 06:56:01 PDT 
(In reply to comment #3)
> Committed r154909: <http://trac.webkit.org/changeset/154909>

It caused a regression on Coordinated Graphics platforms,
the fix is in https://bugs.webkit.org/show_bug.cgi?id=120600