Bug 120221 - copy-webkitlibraries-to-product-directory should accept command-line arguments for extra work required for optional features rather than relying on environment variables
Summary: copy-webkitlibraries-to-product-directory should accept command-line argument...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency treegraph
 
Reported: 2013-08-23 12:25 PDT by Filip Pizlo
Modified: 2014-01-30 16:37 PST (History)
2 users (show)

See Also:


Attachments
the patch (4.84 KB, patch)
2014-01-30 16:28 PST, Filip Pizlo
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-08-23 12:25:22 PDT
Using environment variables is a bit too magical - it's never quite clear who sets the environment variable or who consumes it.  An argument is more explicit.
Comment 1 Filip Pizlo 2014-01-30 16:28:05 PST
Created attachment 222756 [details]
the patch
Comment 2 Mark Hahnenberg 2014-01-30 16:33:37 PST
Comment on attachment 222756 [details]
the patch

r=me
Comment 3 Filip Pizlo 2014-01-30 16:37:55 PST
Landed in http://trac.webkit.org/changeset/163133