RESOLVED FIXED 120189
Web Inspector: Debugger should have "Continue to Here" context menu item 
https://bugs.webkit.org/show_bug.cgi?id=120189
Summary Web Inspector: Debugger should have "Continue to Here" context menu item
Joseph Pecoraro
Reported 2013-08-22 18:08:10 PDT
DebuggerAgent already supports continueToLocation and it is very reasonable. We should add a Continue to Here option. Note, this requires the patch from: <https://webkit.org/b/120169> Web Inspector: Breakpoints in the editors gutter should have a contextmenu
Attachments
[PATCH] Proposed Fix (6.36 KB, patch)
2013-08-22 18:14 PDT, Joseph Pecoraro 		joepeck: review-
joepeck: commit-queue-
DetailsFormatted DiffDiff
[IMAGE] Continue to Here Context Menu Item (66.32 KB, image/png)
2013-08-22 18:32 PDT, Joseph Pecoraro 		no flags
Details
[PATCH] Proposed Fix - Rebaselined (6.78 KB, patch)
2013-08-26 20:31 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-08-22 18:08:21 PDT
<rdar://problem/14815163>
Joseph Pecoraro
Comment 2 2013-08-22 18:14:11 PDT
Created attachment 209419 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2013-08-22 18:30:32 PDT
Comment on attachment 209419 [details] [PATCH] Proposed Fix I'm encountering some unexpected issues using this and debugging on bogojoker.com/shell/ that I want to investigate deeper. I can send out another patch after investigating that.
Joseph Pecoraro
Comment 4 2013-08-22 18:32:24 PDT
Created attachment 209421 [details] [IMAGE] Continue to Here Context Menu Item This is what it looks like.
Timothy Hatcher
Comment 5 2013-08-24 09:10:50 PDT
Looking good!
Joseph Pecoraro
Comment 6 2013-08-26 20:30:55 PDT
Actually, this patch works great once the other bug is fixed: <https://webkit.org/b/120334> Web Inspector: Column Breakpoint not working, may be off by 1 Rebaselining patch due to localizedStrings changes.
Joseph Pecoraro
Comment 7 2013-08-26 20:31:51 PDT
Created attachment 209710 [details] [PATCH] Proposed Fix - Rebaselined
WebKit Commit Bot
Comment 8 2013-08-27 12:21:51 PDT
Comment on attachment 209710 [details] [PATCH] Proposed Fix - Rebaselined Clearing flags on attachment: 209710 Committed r154703: <http://trac.webkit.org/changeset/154703>
WebKit Commit Bot
Comment 9 2013-08-27 12:21:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.