Bug 120189 - Web Inspector: Debugger should have "Continue to Here" context menu item
Summary: Web Inspector: Debugger should have "Continue to Here" context menu item
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 120169
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-22 18:08 PDT by Joseph Pecoraro
Modified: 2013-08-27 12:21 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (6.36 KB, patch)
2013-08-22 18:14 PDT, Joseph Pecoraro 		joepeck: review-
joepeck: commit-queue-
Details | Formatted Diff | Diff
[IMAGE] Continue to Here Context Menu Item (66.32 KB, image/png)
2013-08-22 18:32 PDT, Joseph Pecoraro 		no flags Details
[PATCH] Proposed Fix - Rebaselined (6.78 KB, patch)
2013-08-26 20:31 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-08-22 18:08:10 PDT 
DebuggerAgent already supports continueToLocation and it is very reasonable. We should add a Continue to Here option.

Note, this requires the patch from:
<https://webkit.org/b/120169> Web Inspector: Breakpoints in the editors gutter should have a contextmenu
Comment 1 Radar WebKit Bug Importer 2013-08-22 18:08:21 PDT 
<rdar://problem/14815163>
Comment 2 Joseph Pecoraro 2013-08-22 18:14:11 PDT 
Created attachment 209419 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2013-08-22 18:30:32 PDT 
Comment on attachment 209419 [details]
[PATCH] Proposed Fix

I'm encountering some unexpected issues using this and debugging on bogojoker.com/shell/ that I want to investigate deeper. I can send out another patch after investigating that.
Comment 4 Joseph Pecoraro 2013-08-22 18:32:24 PDT 
Created attachment 209421 [details]
[IMAGE] Continue to Here Context Menu Item

This is what it looks like.
Comment 5 Timothy Hatcher 2013-08-24 09:10:50 PDT 
Looking good!
Comment 6 Joseph Pecoraro 2013-08-26 20:30:55 PDT 
Actually, this patch works great once the other bug is fixed:
<https://webkit.org/b/120334> Web Inspector: Column Breakpoint not working, may be off by 1

Rebaselining patch due to localizedStrings changes.
Comment 7 Joseph Pecoraro 2013-08-26 20:31:51 PDT 
Created attachment 209710 [details]
[PATCH] Proposed Fix - Rebaselined
Comment 8 WebKit Commit Bot 2013-08-27 12:21:51 PDT 
Comment on attachment 209710 [details]
[PATCH] Proposed Fix - Rebaselined

Clearing flags on attachment: 209710

Committed r154703: <http://trac.webkit.org/changeset/154703>
Comment 9 WebKit Commit Bot 2013-08-27 12:21:53 PDT 
All reviewed patches have been landed.  Closing bug.