Bug 120169 - Web Inspector: Breakpoints in the editors gutter should have a contextmenu
Summary: Web Inspector: Breakpoints in the editors gutter should have a contextmenu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks: 120189
  Show dependency tree / graph
 
Reported: 2013-08-22 12:53 PDT by Joseph Pecoraro
Modified: 2013-08-24 11:57 PDT (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (7.53 KB, patch)
2013-08-22 13:00 PDT, Joseph Pecoraro 		timothy: review+
Details | Formatted Diff | Diff
[IMAGE] New Context Menus (99.52 KB, image/png)
2013-08-22 13:01 PDT, Joseph Pecoraro 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-08-22 12:53:09 PDT 
Editor gutters should have a context menu. So you can add / modify breakpoints directly from the sidebar.
Comment 1 Radar WebKit Bug Importer 2013-08-22 12:53:27 PDT 
<rdar://problem/14811085>
Comment 2 Joseph Pecoraro 2013-08-22 13:00:26 PDT 
Created attachment 209385 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2013-08-22 13:01:00 PDT 
Created attachment 209386 [details]
[IMAGE] New Context Menus
Comment 4 Joseph Pecoraro 2013-08-22 13:04:03 PDT 
Comment on attachment 209385 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=209385&action=review

> Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js:704
> +            contextMenu.appendItem(WebInspector.UIString("Add Breakpoint"), addBreakpoint.bind(this));

Would anyone prefer the wording "Create Breakpoint"? Xcode does not have an equivalent of this menu item for adding/creating a breakpoint.
Comment 5 Timothy Hatcher 2013-08-24 09:21:26 PDT 
Comment on attachment 209385 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=209385&action=review

>> Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js:704
>> +            contextMenu.appendItem(WebInspector.UIString("Add Breakpoint"), addBreakpoint.bind(this));
> 
> Would anyone prefer the wording "Create Breakpoint"? Xcode does not have an equivalent of this menu item for adding/creating a breakpoint.

I like Add better.

> Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js:723
> +            contextMenu.appendItem(WebInspector.UIString("Reveal in Debugger Navigator"), revealInSidebar);

I think Debugger Navigator sounds funny. This would read better as Debugger Navigation Sidebar.
Comment 6 Joseph Pecoraro 2013-08-24 11:57:58 PDT 
Committed <http://trac.webkit.org/changeset/154550>.