WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
120169
Web Inspector: Breakpoints in the editors gutter should have a contextmenu
https://bugs.webkit.org/show_bug.cgi?id=120169
Summary
Web Inspector: Breakpoints in the editors gutter should have a contextmenu
Joseph Pecoraro
Reported
2013-08-22 12:53:09 PDT
Editor gutters should have a context menu. So you can add / modify breakpoints directly from the sidebar.
Attachments
[PATCH] Proposed Fix
(7.53 KB, patch)
2013-08-22 13:00 PDT
,
Joseph Pecoraro
timothy
: review+
Details
Formatted Diff
Diff
[IMAGE] New Context Menus
(99.52 KB, image/png)
2013-08-22 13:01 PDT
,
Joseph Pecoraro
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2013-08-22 12:53:27 PDT
<
rdar://problem/14811085
>
Joseph Pecoraro
Comment 2
2013-08-22 13:00:26 PDT
Created
attachment 209385
[details]
[PATCH] Proposed Fix
Joseph Pecoraro
Comment 3
2013-08-22 13:01:00 PDT
Created
attachment 209386
[details]
[IMAGE] New Context Menus
Joseph Pecoraro
Comment 4
2013-08-22 13:04:03 PDT
Comment on
attachment 209385
[details]
[PATCH] Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=209385&action=review
> Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js:704 > + contextMenu.appendItem(WebInspector.UIString("Add Breakpoint"), addBreakpoint.bind(this));
Would anyone prefer the wording "Create Breakpoint"? Xcode does not have an equivalent of this menu item for adding/creating a breakpoint.
Timothy Hatcher
Comment 5
2013-08-24 09:21:26 PDT
Comment on
attachment 209385
[details]
[PATCH] Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=209385&action=review
>> Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js:704 >> + contextMenu.appendItem(WebInspector.UIString("Add Breakpoint"), addBreakpoint.bind(this)); > > Would anyone prefer the wording "Create Breakpoint"? Xcode does not have an equivalent of this menu item for adding/creating a breakpoint.
I like Add better.
> Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js:723 > + contextMenu.appendItem(WebInspector.UIString("Reveal in Debugger Navigator"), revealInSidebar);
I think Debugger Navigator sounds funny. This would read better as Debugger Navigation Sidebar.
Joseph Pecoraro
Comment 6
2013-08-24 11:57:58 PDT
Committed <
http://trac.webkit.org/changeset/154550
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug