Bug 120131 - REGRESSION (r154022): webkitbot failed to make a changelog for a revert in https://bugs.webkit.org/show_bug.cgi?id=120129
Summary: REGRESSION (r154022): webkitbot failed to make a changelog for a revert in ht...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
: 119894 (view as bug list)
Depends on:
Reported: 2013-08-21 12:52 PDT by Tim Horton
Modified: 2013-08-22 00:25 PDT (History)
6 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-08-21 12:52:22 PDT
In https://bugs.webkit.org/show_bug.cgi?id=120129 I requested a revert of http://trac.webkit.org/changeset/154399.

webkitbot made the bug and the patch, but the patch had lots of OOPS in it (in fact it looks like it hasn't been modified at all!).

This is not useful.

Is this because the changelog format changed recently? Or something else?
Comment 1 Tim Horton 2013-08-21 13:02:57 PDT
update_with_unreviewed_message looks for a line that no longer exists:

def update_with_unreviewed_message(self, message):
        first_boilerplate_line_regexp = re.compile(
                "%sNeed a short description \(OOPS!\)\." % self._changelog_indent)

Dino's change makes it look like this:

<Need the bug URL (OOPS!)> Need a short description (OOPS!)

Which doesn't match anymore. I'll fix this.
Comment 2 Tim Horton 2013-08-21 13:25:36 PDT
Actually, I'm going to roll out the original patch. I don't like the new format enough to spend the time to fix this, the original author can do it if they want :)
Comment 3 Tim Horton 2013-08-21 13:26:18 PDT
https://bugs.webkit.org/show_bug.cgi?id=119766 is the bug that changed this, btw.
Comment 4 Zan Dobersek 2013-08-22 00:25:10 PDT
*** Bug 119894 has been marked as a duplicate of this bug. ***