Bug 119766 - Make bug url more human friendly in ChangeLog
Summary: Make bug url more human friendly in ChangeLog
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Depends on: 152898
  Show dependency treegraph
Reported: 2013-08-13 13:40 PDT by Dean Jackson
Modified: 2024-02-24 15:32 PST (History)
7 users (show)

See Also:

Patch (3.72 KB, patch)
2013-08-13 13:49 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (3.96 KB, patch)
2013-08-13 14:00 PDT, Dean Jackson
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-08-13 13:40:52 PDT
It's 2013 - we should not be exposing our bugzilla tool URLs to the web when we have a nice redirect already in place.

Update prepare-ChangeLog to use https://webkit.org/b/id rather than the longer bugzilla form.

The hitch might be to make sure webkit-patch can detect the shorter url.
Comment 1 Joseph Pecoraro 2013-08-13 13:45:32 PDT
I would even prefer a single line for the bug and bug title, like radars:

    <http://webkit.org/b/119766> Make bug url more human friendly in ChangeLog

That would also make `git log --oneline` history for WebKit way easier to read then the current mess.
Comment 2 Dean Jackson 2013-08-13 13:49:51 PDT
Created attachment 208671 [details]
Comment 3 Dean Jackson 2013-08-13 13:51:03 PDT
OK. Ignore this patch then. BTW, the patch was created with the changes, so webkit-patch works fine.
Comment 4 Dean Jackson 2013-08-13 14:00:22 PDT
Created attachment 208673 [details]
Comment 5 Mark Rowe (bdash) 2013-08-13 14:03:03 PDT
Comment on attachment 208673 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=208673&action=review

> Tools/Scripts/prepare-ChangeLog:198
> +    my $bugReadableURL;

readableBugURL would be more readable than bugReadableURL.
Comment 6 Dean Jackson 2013-08-13 14:13:13 PDT
Committed r154022: <http://trac.webkit.org/changeset/154022>
Comment 7 Tim Horton 2013-08-21 13:09:44 PDT
This patch broke webkitbot's rollout ability, as it entirely failed to update changelog.py's changelog parsing code. I'm going to fix it in https://bugs.webkit.org/show_bug.cgi?id=120131.
Comment 8 Tim Horton 2013-08-21 13:29:45 PDT
Rolled out in http://trac.webkit.org/changeset/154406.
Comment 9 Ryosuke Niwa 2013-08-21 13:31:29 PDT
There are just too many tools that rely on the old format.  Using wekbit.org/b/<~> URL is good but wrapping them in <> and putting the URL and bug title isn't.

It makes the long way too long for some bugs and wrapping it in < > breaks all sorts of tools.
Comment 10 Ahmad Saleem 2024-02-24 15:32:18 PST
@Jonathan & Ryan - do we need this now?

We still have 'prepare-ChangeLog' script.