Bug 119643 - [Mac] some track language tags are not recognized
Summary: [Mac] some track language tags are not recognized
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks: 120335
  Show dependency tree / graph
 
Reported: 2013-08-09 15:48 PDT by Eric Carlson
Modified: 2013-08-26 17:32 PDT (History)
8 users (show)

See Also:

Attachments
Proposed patch (2.38 KB, patch)
2013-08-09 15:55 PDT, Eric Carlson 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Proposed patch (21.63 KB, patch)
2013-08-23 13:10 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-08-09 15:48:04 PDT 
If a movie's language code is stored as a QuickTime 5-bit packed code there aren't enough bits for a full RFC 4646 language tag. The AVFoundation API we use returns NULL in this case, so we have to try another to see if we can get the ISO 639-2/T language code.
Comment 1 Radar WebKit Bug Importer 2013-08-09 15:48:38 PDT 
<rdar://problem/14701711>
Comment 2 Eric Carlson 2013-08-09 15:55:44 PDT 
Created attachment 208462 [details]
Proposed patch
Comment 3 Dean Jackson 2013-08-09 15:57:05 PDT 
Comment on attachment 208462 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208462&action=review

> Source/WebCore/ChangeLog:13
> +            QuickTime langage code.

typo language
Comment 4 Eric Carlson 2013-08-09 16:09:26 PDT 
Committed in https://trac.webkit.org/r153912.
Comment 5 Antti Koivisto 2013-08-11 08:48:24 PDT 
Looks like this made a bunch of tests fail https://bugs.webkit.org/show_bug.cgi?id=119661
Comment 6 Ryosuke Niwa 2013-08-11 22:25:33 PDT 
This patch caused 26 tests to fail:
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r153912%20(11876)/results.html
Aug 09 16:21	153912	failure	#11876	Failed 28 failures 24 new passes 3 flakes
Aug 09 16:08	153910	failure	#11875	Failed 2 failures 25 new passes 5 flakes
Comment 7 Eric Carlson 2013-08-12 09:49:23 PDT 
Reverted in https://trac.webkit.org/r153945.
Comment 8 Build Bot 2013-08-22 20:05:28 PDT 
Comment on attachment 208462 [details]
Proposed patch

Attachment 208462 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1527454
Comment 9 Eric Carlson 2013-08-23 13:10:34 PDT 
Created attachment 209498 [details]
Proposed patch
Comment 10 Jer Noble 2013-08-23 14:37:03 PDT 
Comment on attachment 209498 [details]
Proposed patch

r=me.
Comment 11 Eric Carlson 2013-08-23 15:47:27 PDT 
Committed r154527 - https://trac.webkit.org/r154527.