Bug 119483 - XMLTreeViewer should be created only in the XML viewer mode
Summary: XMLTreeViewer should be created only in the XML viewer mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vivek Galatage
URL:
Keywords:
: 119723 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-08-05 01:45 PDT by Vivek Galatage
Modified: 2013-08-12 23:47 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.19 KB, patch)
2013-08-05 01:54 PDT, Vivek Galatage 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vivek Galatage 2013-08-05 01:45:42 PDT 
XMLTreeViewer is created even for the XSL transform. This should be avoided.

It should also remove unnecessary conditional check while deciding for XML viewer mode. 

These patches are already reviewed in blink. Combining these relevant patches into a single patch for webkit.

https://codereview.chromium.org/19552003/
https://codereview.chromium.org/22150003/

Patch follows.
Comment 1 Vivek Galatage 2013-08-05 01:54:33 PDT 
Created attachment 208112 [details]
Patch
Comment 2 Vivek Galatage 2013-08-05 09:00:45 PDT 
@ap, thanks for the review.
Comment 3 WebKit Commit Bot 2013-08-05 09:24:52 PDT 
Comment on attachment 208112 [details]
Patch

Clearing flags on attachment: 208112

Committed r153707: <http://trac.webkit.org/changeset/153707>
Comment 4 WebKit Commit Bot 2013-08-05 09:24:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Ryosuke Niwa 2013-08-12 23:47:39 PDT 
*** Bug 119723 has been marked as a duplicate of this bug. ***