Bug 119035 – [EFL][CMAKE] Fix wrong syntax about option commands

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

Second value of option command should be description.

option(<option_variable> "help string describing option" [initial value])

http://www.cmake.org/cmake/help/v2.8.11/cmake.html#command:option

[Ryuan Choi]

Created attachment 207374 [details]
Patch

[Chris Dumez]

Comment on attachment 207374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207374&action=review

> Source/cmake/OptionsEfl.cmake:211
> +    option(ENABLE_EGL "Enable EGL Support")

Shouldn't we keep ON as 3rd argument? It seems the default value is OFF otherwise.

> Source/cmake/OptionsEfl.cmake:221
> +        option(ENABLE_GLES2 "Enable GLES Support")

Ditto.

[Ryuan Choi]

(In reply to comment #2)
> (From update of attachment 207374 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207374&action=review
> 
> > Source/cmake/OptionsEfl.cmake:211
> > +    option(ENABLE_EGL "Enable EGL Support")
> 
> Shouldn't we keep ON as 3rd argument? It seems the default value is OFF otherwise.
> 
> > Source/cmake/OptionsEfl.cmake:221
> > +        option(ENABLE_GLES2 "Enable GLES Support")
> 
> Ditto.

Yes, so these were OFF as default. (Now, ON is just description)
It is the reason why I make this patch. :)

I traced original bugs and they intended OFF.
https://bugs.webkit.org/show_bug.cgi?id=105602
https://bugs.webkit.org/show_bug.cgi?id=105816

[Chris Dumez]

Comment on attachment 207374 [details]
Patch

Ok. r=me. No behavior change, just proper description.

[WebKit Commit Bot]

Comment on attachment 207374 [details]
Patch

Clearing flags on attachment: 207374

Committed r153080: <http://trac.webkit.org/changeset/153080>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Kalyan]

Comment on attachment 207374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207374&action=review

> Source/cmake/OptionsEfl.cmake:222
>  

Didn't follow this completely. In this case GLES support should be enabled(We force GLES usage with EGL).If I understood it right this will default to off now unless we enable both EGL and GLES options

[Kalyan]

Comment on attachment 207374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207374&action=review

> Source/cmake/OptionsEfl.cmake:223
>          if (ENABLE_GLES2)

sorry, ignore my comment.